Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from k8s.gcr.io to registry.k8s.io #376

Merged
merged 1 commit into from
Apr 14, 2023
Merged

chore: migrate from k8s.gcr.io to registry.k8s.io #376

merged 1 commit into from
Apr 14, 2023

Conversation

ahmedwaleedmalik
Copy link
Contributor

Fixes #

Proposed Changes

Kubernetes is migrating its image registry from k8s.gcr.io to registry.k8s.io.

Part of kubernetes/k8s.io#4780.

Release Note

NONE

Docs

xref knative/operator#1342

@knative-prow
Copy link

knative-prow bot commented Apr 12, 2023

Welcome @ahmedwaleedmalik! It looks like this is your first PR to knative-sandbox/eventing-github 🎉

@ahmedwaleedmalik
Copy link
Contributor Author

@pierDipi can you PTAL?

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested via

podman pull registry.k8s.io/fluentd-elasticsearch:v2.0.4

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #376 (db4d96e) into main (1a69bb9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   40.02%   40.02%           
=======================================
  Files          17       17           
  Lines         742      742           
=======================================
  Hits          297      297           
  Misses        441      441           
  Partials        4        4           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@knative-prow knative-prow bot merged commit d6a0392 into knative-extensions:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants