Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from k8s.gcr.io to registry.k8s.io #468

Merged
merged 1 commit into from
Apr 19, 2023
Merged

chore: migrate from k8s.gcr.io to registry.k8s.io #468

merged 1 commit into from
Apr 19, 2023

Conversation

ahmedwaleedmalik
Copy link
Contributor

Fixes #

Proposed Changes

Kubernetes is migrating its image registry from k8s.gcr.io to registry.k8s.io.

Part of kubernetes/k8s.io#4780.

Release Note

NONE

Docs

xref knative/operator#1342

@knative-prow
Copy link

knative-prow bot commented Apr 12, 2023

Welcome @ahmedwaleedmalik! It looks like this is your first PR to knative-sandbox/sample-source 🎉

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 12, 2023

Hi @ahmedwaleedmalik. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Contributor Author

@lberk can you PTAL?

@ahmedwaleedmalik
Copy link
Contributor Author

@gab-satchi can you PTAL?

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023
@knative-prow knative-prow bot merged commit 765e0be into knative-extensions:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants