Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger reconciler tests for ConsumerGroup scaling #1756

Conversation

aavarghese
Copy link
Contributor

@aavarghese aavarghese commented Jan 18, 2022

Signed-off-by: aavarghese avarghese@us.ibm.com

Part of #1537

/cc @pierDipi

Proposed Changes

  • Adding new Trigger reconciler unit tests for consumer scheduling and scaling

Release Note


Docs

@knative-prow-robot knative-prow-robot added area/control-plane size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 18, 2022
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1756 (3565585) into main (178b818) will increase coverage by 1.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1756      +/-   ##
============================================
+ Coverage     66.21%   67.67%   +1.45%     
- Complexity      614      617       +3     
============================================
  Files           129      129              
  Lines          5293     5330      +37     
  Branches        177      177              
============================================
+ Hits           3505     3607     +102     
+ Misses         1503     1438      -65     
  Partials        285      285              
Flag Coverage Δ
java-unittests 82.34% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ls/kafka/eventing/v1alpha1/consumer_group_types.go 0.00% <ø> (ø)
...ol-plane/pkg/reconciler/trigger/v2/controllerv2.go 58.49% <100.00%> (ø)
...ntrol-plane/pkg/reconciler/trigger/v2/triggerv2.go 87.77% <100.00%> (+87.77%) ⬆️
control-plane/pkg/reconciler/channel/channel.go 61.88% <0.00%> (-2.97%) ⬇️
control-plane/pkg/reconciler/sink/kafka_sink.go 71.59% <0.00%> (+0.52%) ⬆️
control-plane/pkg/reconciler/broker/broker.go 67.74% <0.00%> (+0.59%) ⬆️
...dispatcher/impl/consumer/BaseConsumerVerticle.java 93.75% <0.00%> (+6.25%) ⬆️
...tcher/impl/consumer/UnorderedConsumerVerticle.java 100.00% <0.00%> (+13.04%) ⬆️
control-plane/pkg/receiver/address.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178b818...3565585. Read the comment docs.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review of this PR, looks good overall.

@pierDipi pierDipi self-requested a review January 18, 2022 21:00
Signed-off-by: aavarghese <avarghese@us.ibm.com>
Signed-off-by: aavarghese <avarghese@us.ibm.com>
@aavarghese aavarghese force-pushed the consumer-scheduling-scaling-triggertest branch from 3365c5e to f16b88f Compare January 18, 2022 23:40
Signed-off-by: aavarghese <avarghese@us.ibm.com>
@aavarghese aavarghese requested a review from pierDipi January 21, 2022 11:52
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
control-plane/pkg/reconciler/trigger/v2/triggerv2.go 0.0% 90.0% 90.0

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@knative-prow-robot knative-prow-robot merged commit 7d23f5f into knative-extensions:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants