Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markusthoemmes as Scaling Working Group Lead. #11

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

josephburnett
Copy link

I propose to add Markus Thömmes (Red Hat) as an additional Scaling Working Group Lead.

Requirements: (link):

Working group leads, or just ‘leads’, are approvers of an entire area that have demonstrated good judgement and responsibility. Leads accept design proposals and approve design decisions for their area of ownership.

Getting to be a lead of an existing working group:

  • Recognized as having expertise in the group’s subject matter.
  • Approver for some part of the codebase for at least 3 months.
  • Member for at least 1 year or 50% of project lifetime, whichever is shorter.
  • Primary reviewer for 20 substantial PRs.
  • Reviewed or merged at least 50 PRs.
  • Sponsored by the technical oversight committee.

Additional requirements for leads of a new working group:

  • Originally authored or contributed major functionality to the group's area.
  • An approver in the OWNERS file for the group’s code.

Markus has expertise in the Scaling WG subject matter. He has worked deeply with the core autoscaling algorithm to stabilize and improve it (#1091, #1194, #3289). Additionally he was a core contributor to Open Whisk and has prior expertise in the autoscaling problem space (Open Whisk commits).

He has been an approver in the Scaling WG for over 6 months (Nov. 7, 2018). He has been an active code contributor and reviewer. Additionally he has contributed directly to the working group's roadmap (2019 roadmap).

Markus has contributed a lot of critical relayering to the autoscaling code base. E.g. moving activation to the Autoscaler from the Activator (#2198, #2215, #1923) and now separating autoscaler metrics from the decider to allow for HPA scale-to-zero and HPA custom metrics (#4236, #4007, #4260, #4237). As such, he has a good view and vision for the full autoscaling system.

Markus has demonstrated the good judgement and responsibility necessary to serve as Scaling Working Group Lead over a sustained period of time.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2019
@josephburnett
Copy link
Author

josephburnett commented Jun 5, 2019

Technical Oversight Committee: @evankanderson @vaikas-google @mattmoor, please review.

@mattmoor
Copy link
Member

mattmoor commented Jun 5, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2019
@evankanderson
Copy link
Member

/lgtm
/approve

@josephburnett
Copy link
Author

/assign @mbehrendt

@evankanderson and @mattmoor have approved. Need steering committee approval because of OWNERS file.

@vaikas
Copy link
Contributor

vaikas commented Jun 6, 2019

/lgtm

@josephburnett
Copy link
Author

@rgregg or @isdal, can you please approve this?

@mbehrendt
Copy link

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, josephburnett, mbehrendt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2019
@knative-prow-robot knative-prow-robot merged commit 4f02092 into knative:master Jun 6, 2019
jwcesign pushed a commit to jwcesign/community that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants