Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from k8s.gcr.io to registry.k8s.io #5436

Merged

Conversation

shikharcodes
Copy link
Contributor

This PR is a part of kubernetes/k8s.io#4780.

Proposed Changes

This PR does the following changes:

  • modify all occurrences of k8s.gcr.io to registry.k8s.io.

Signed-off-by: Shikhar Saxena <shikhar06jan@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 17, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: shikharcodes / name: Shikhar Saxena (c0e59ae)

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c0e59ae
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/63efb9a090ca0b00085c9952
😎 Deploy Preview https://deploy-preview-5436--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow
Copy link

knative-prow bot commented Feb 17, 2023

Welcome @shikharcodes! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 17, 2023
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@psschwei
Copy link
Contributor

I'm assuming that all images in the old registry are present in the new registry? (Usually I'd check myself, but am not able to do so until next week, if someone could confirm 🙏 )

@dprotaso
Copy link
Member

/approve

images can be pulled

@knative-prow
Copy link

knative-prow bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pierDipi, shikharcodes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@knative-prow knative-prow bot merged commit cb705a3 into knative:main Feb 22, 2023
@shikharcodes shikharcodes deleted the ss/k8s-gcr-io-to-registry-k8s-io branch March 4, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants