Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Stop skipping Broker Tests #640

Merged
merged 2 commits into from
Oct 3, 2019

Conversation

Harwayne
Copy link
Contributor

@Harwayne Harwayne commented Oct 2, 2019

Fixes #639

Proposed Changes

Release Note

NONE

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 2, 2019
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test-and-release labels Oct 2, 2019
@Harwayne Harwayne marked this pull request as ready for review October 2, 2019 22:35
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2019
@nachocano
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@Harwayne Harwayne changed the title Update knative/eventing. Stop Oct 2, 2019
@Harwayne Harwayne changed the title Stop Stop skipping Broker Tests Oct 2, 2019
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2019
@knative-prow-robot knative-prow-robot merged commit 7bb12f8 into knative:master Oct 3, 2019
@Harwayne Harwayne deleted the bump-eventing branch October 3, 2019 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broker E2E tests broken
5 participants