Delete (Cluster)Role(Bindings) as a final cleanup step. #141
Conversation
There was a problem hiding this comment.
@Cynocracy: 0 warnings.
In response to this:
This allows us to take advantage of the permissions granted to cluster admins
when performing cleanup. If the approach in #109
is approved, this will become necessary. Additionally, it makes sense to remove roles as the final
step to allow human Operators to modify any resources they may have permissions on as a result of the Knative installation (that is, we should not remove any access until we are 'almost done' cleaning up)./lint
Proposed Changes
*Delete roles and rolebindings as a final cleanup step.
Release Note
Delete roles and rolebindings as a final cleanup step.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
config/role.yaml
Outdated
| @@ -26,9 +26,6 @@ rules: | |||
| - apps | |||
| resources: | |||
| - deployments | |||
| - daemonsets | |||
There was a problem hiding this comment.
whoops, this shouldn't be here, one moment..
This allows us to take advantage of the permissions granted to cluster admins when performing cleanup. If the approach in knative#109 is approved, this will become necessary. Additionally, it makes sense to remove roles as the final step to allow human Operators to modify any resources they may have permissions on as a result of the Knative installation (that is, we should not remove any access until we are 'almost done' cleaning up).
|
Whoops, looks like I need to update manifestival, one moment. |
Cynocracy
changed the title
|
Blocked on #142 |
|
is this still WIP? |
Cynocracy
changed the title
|
/assign @matzew See also knative/serving-operator#359 |
|
Oh, sorry k4leung4, missed your comment, no it is no longer WIP. |
|
@googlebot I consent |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cynocracy, k4leung4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This allows us to take advantage of the permissions granted to cluster admins
when performing cleanup. If the approach in #109
is approved, this will become necessary. Additionally, it makes sense to remove roles as the final
step to allow human Operators to modify any resources they may have permissions on as a result of the Knative installation (that is, we should not remove any access until we are 'almost done' cleaning up).
/lint
Proposed Changes
*Delete roles and rolebindings as a final cleanup step.
Release Note