Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Pass config from main to the controller. #202

Merged

Conversation

markusthoemmes
Copy link
Contributor

Proposed Changes

To align with knative/operator#21 and to be able to use this controller as a "library" (to compile multiple operators into one binary), this moves the flag definition to the main.go file and passes the built config through.

Release Note

NONE

/assign @aliok @houshengbo

Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusthoemmes: 0 warnings.

In response to this:

Proposed Changes

To align with knative/operator#21 and to be able to use this controller as a "library" (to compile multiple operators into one binary), this moves the flag definition to the main.go file and passes the built config through.

Release Note

NONE

/assign @aliok @houshengbo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Makes a lot of sense.
I know we're not really going to use this operator's pkg as a library, but aligning with the new operator is nice.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 2e538b3 into knative:master Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants