From 02403a53672d29f365671c9894fbc5ec7e88e228 Mon Sep 17 00:00:00 2001
From: Ben Moss <benm@vmware.com>
Date: Tue, 15 Jun 2021 03:40:20 -0400
Subject: [PATCH] Remove flaky test (#5508)

It was not really testing anything but the library
---
 pkg/adapter/v2/cloudevents_test.go | 128 -----------------------------
 1 file changed, 128 deletions(-)

diff --git a/pkg/adapter/v2/cloudevents_test.go b/pkg/adapter/v2/cloudevents_test.go
index 568b289e6fe..f911eb71160 100644
--- a/pkg/adapter/v2/cloudevents_test.go
+++ b/pkg/adapter/v2/cloudevents_test.go
@@ -17,23 +17,14 @@ limitations under the License.
 package adapter
 
 import (
-	"bytes"
 	"context"
-	"fmt"
-	"io/ioutil"
-	"math/rand"
-	nethttp "net/http"
-	"net/url"
 	"os"
 	"strconv"
-	"sync"
 	"testing"
 	"time"
 
 	cloudevents "github.com/cloudevents/sdk-go/v2"
-	"github.com/cloudevents/sdk-go/v2/event"
 	"github.com/cloudevents/sdk-go/v2/protocol/http"
-	"github.com/google/go-cmp/cmp"
 	duckv1 "knative.dev/pkg/apis/duck/v1"
 	"knative.dev/pkg/source"
 
@@ -302,125 +293,6 @@ func TestNewCloudEventsClient_request(t *testing.T) {
 	}
 }
 
-func TestNewCloudEventsClient_receiver(t *testing.T) {
-	sampleEvent := func() *cloudevents.Event {
-		event := cloudevents.NewEvent(cloudevents.VersionV1)
-		event.SetID("abc-123")
-		event.SetSource("unit/test")
-		event.SetType("unit.type")
-		event.SetDataContentType("application/json")
-		return &event
-	}
-
-	testCases := map[string]struct {
-		Headers      nethttp.Header
-		Body         []byte
-		ExpectedBody string
-		WantTimeout  bool
-	}{
-		"binary event": {
-			Headers: map[string][]string{
-				"content-type":   {"application/json"},
-				"ce-specversion": {"1.0"},
-				"ce-id":          {"abc-123"},
-				"ce-type":        {"unit.type"},
-				"ce-source":      {"unit/test"},
-			},
-			Body:         []byte(`{"type": "binary"}`),
-			ExpectedBody: `{"type": "binary"}`,
-		},
-		"structured event": {
-			Headers: map[string][]string{
-				"content-type": {"application/cloudevents+json"},
-			},
-			Body: []byte(`{
-				"specversion": "1.0",
-				"id": "abc-123",
-				"source": "unit/test",
-				"type": "unit.type",
-				"datacontenttype": "application/json",
-				"data": {"type": "structured"}
-			}`),
-			ExpectedBody: ` {"type": "structured"}`,
-		},
-		"malformed event": {
-			Headers: map[string][]string{
-				"ce-type": {"err.event"},
-			},
-			WantTimeout: true,
-		},
-	}
-	for n, tc := range testCases {
-		t.Run(n, func(t *testing.T) {
-			port := rand.Intn(16383) + 49152 // IANA Dynamic Ports range
-			ceClient, err := NewCloudEventsClientWithOptions(nil, &mockReporter{}, cloudevents.WithPort(port))
-			if err != nil {
-				t.Errorf("failed to create CE client: %v", err)
-			}
-
-			ctx, cancel := context.WithTimeout(context.Background(), time.Second)
-			defer cancel()
-
-			events := make(chan event.Event, 1)
-			defer close(events)
-			errors := make(chan error, 1)
-			defer close(errors)
-
-			var wg sync.WaitGroup
-			wg.Add(1)
-			go func() {
-				wg.Done()
-				err := ceClient.StartReceiver(ctx, func(event event.Event) error {
-					events <- event
-					return nil
-				})
-				if err != nil {
-					errors <- err
-				}
-			}()
-			wg.Wait()                         // wait for the above goroutine to be running
-			time.Sleep(50 * time.Millisecond) // wait for the receiver to start
-
-			target, err := url.Parse(fmt.Sprintf("http://localhost:%d", port))
-			if err != nil {
-				t.Errorf("failed to parse target URL: %v", err)
-			}
-
-			req := &nethttp.Request{
-				Method:        "POST",
-				URL:           target,
-				Header:        tc.Headers,
-				Body:          ioutil.NopCloser(bytes.NewReader(tc.Body)),
-				ContentLength: int64(len(tc.Body)),
-			}
-
-			_, err = nethttp.DefaultClient.Do(req)
-			if err != nil {
-				t.Errorf("failed to execute the request %s", err.Error())
-			}
-
-			select {
-			case <-ctx.Done():
-				if !tc.WantTimeout {
-					t.Errorf("unexpected receiver timeout")
-				}
-			case got := <-events:
-				if tc.WantTimeout {
-					t.Errorf("unexpected event received")
-				}
-				if diff := cmp.Diff(sampleEvent().Context, got.Context); diff != "" {
-					t.Errorf("unexpected events.Context (-want, +got) = %v", diff)
-				}
-				if diff := cmp.Diff(tc.ExpectedBody, string(got.Data())); diff != "" {
-					t.Errorf("unexpected events.Data (-want, +got) = %v", diff)
-				}
-			case err := <-errors:
-				t.Errorf("failed to start receiver: %v", err)
-			}
-		})
-	}
-}
-
 func validateSent(t *testing.T, ce *test.TestCloudEventsClient, want string) {
 	if got := len(ce.Sent()); got != 1 {
 		t.Error("Expected 1 event to be sent, got", got)