Channel Conformance Test - Tracing

[Harwayne]

Problem
All conforming Channels are expected to generate traces. We need to have a test that we can run against a specific Channel implementation to determine if it is generating traces correctly.

We require the following spans:

• The request to POST to the Channel. -- Annotated with the Channel's name.
• The request to each Subscriber. -- Annotated with the Subscription's name.
• The request to each Reply. -- Annotated with the Subscription's name.

It would also be good to have, but not strictly required to include Spans for all internal details of the request. For example, if the Channel dispatcher sends to PubSub, it would be nice if there were spans for sending the event to PubSub and receiving the event from PubSub.

Persona:
System Integrator

Exit Criteria
A test in the Channel conformance suite that will determine if the required spans are recorded and annotated with the required information.

[Harwayne]

/project Observability To do

[Harwayne]

/assign

[knative-prow-robot]

@Harwayne: A column is not provided or it's not valid for the project Observability. Please provide one of the following columns in the command:
[To do In progress Review in progress Reviewer approved Done]

In response to this:

/project Observability In Progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Harwayne]

/project Observability In progress

[knative-prow-robot]

@Harwayne: You have successfully moved the project card for this issue to column In progress (ID 6212148).

In response to this:

/project Observability In progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Harwayne]

/project Channels In progress

[Harwayne]

/milestone v0.10.0

[matzew]

Some work is in there: https://github.com/knative/eventing/blob/master/test/conformance/channel_tracing_test.go#L29

[matzew]

/assign @matzew

[aliok]

/assign @aliok

I can work on this along with #1960

[aliok]

I will stop working on this one.
I can't make tracing running properly on Minikube nor on OpenShift and I don't have access to GKE setup that the Prow job uses with GKE's Istio Addon.

Some discussion here: https://knative.slack.com/archives/C9JP909F0/p1586885155386900

@aslom How did you develop the existing tracing tests? Did you target GKE during development?

Also, I see following in 0.14 serving release notes here: https://github.com/knative/serving/releases.

Monitoring Bundle is deprecated

What kind of effects does this have on the tracing conformance tests we're trying to implement? Do we still care about them?

[aliok]

/unassign @aliok

[aslom]

@aliok I was using external cluster however that was few months ago so there may have been chnages in cloudevents go SDK that changed how tracing works

[aliok]

@Harwayne I see the test in https://github.com/knative/eventing/blob/master/test/conformance/helpers/channel_tracing_test_helper.go is doing pretty much what's described in this ticket.

Is there anything else that's missing in your opinion?
If not, let's close this one.

[aliok]

/close

I am going to close this one. I think the current channel tracing conformance tests do more than what's defined in the spec.

[knative-prow-robot]

@aliok: Closing this issue.

In response to this:

/close

I am going to close this one. I think the current channel tracing conformance tests do more than what's defined in the spec.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.