Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance testing for channel metadata #1960

Closed
aslom opened this issue Sep 24, 2019 · 8 comments · Fixed by #2963
Closed

Conformance testing for channel metadata #1960

aslom opened this issue Sep 24, 2019 · 8 comments · Fixed by #2963
Assignees
Labels
area/channels area/test-and-release Test infrastructure, tests or release kind/feature-request proposal/0.13 Proposed (not planned) work items for 0.13 release
Milestone

Comments

@aslom
Copy link
Member

aslom commented Sep 24, 2019

Problem
From channel specification extracted testable
“Each channel is namespaced and MUST have the following:

  • label of messaging.knative.dev/subscribable: "true"
  • The category channel.

Persona:
Which persona is this feature for?

System Integrator, Contributors

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Test runs without errors for in-memory channel

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

1h

Additional context (optional)
Add any other context about the feature request here.

@aslom
Copy link
Member Author

aslom commented Sep 24, 2019

Test
Channel is created by test e2e (by default in-memory, can be configured ot be Kafka with helpers)
Verify the channel is namespaced (?)
Verify the channel has label of messaging.knative.dev/subscribable: "true" Verify the channel has he category channel`.

@aslom
Copy link
Member Author

aslom commented Sep 24, 2019

/project Channels In progress

@knative-prow-robot
Copy link
Contributor

@aslom: You must be a member of the knative/eventing github team to set the project and column.

In response to this:

/project Channels In progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aslom
Copy link
Member Author

aslom commented Sep 24, 2019

@Harwayne
Copy link
Contributor

/project Channels In progress

@akashrv akashrv modified the milestones: v0.10.0, v0.11.0 Oct 3, 2019
@grantr
Copy link
Contributor

grantr commented Jan 14, 2020

@aslom do you know the state of this effort? Do we have a conformance tests for channel metadata now?

@grantr grantr added the proposal/0.13 Proposed (not planned) work items for 0.13 release label Jan 14, 2020
@grantr grantr removed this from the v0.11.0 milestone Jan 14, 2020
@paulrossman paulrossman added this to the v0.13.0 milestone Jan 24, 2020
@paulrossman paulrossman removed this from the v0.13.0 milestone Mar 3, 2020
@akashrv akashrv added the area/test-and-release Test infrastructure, tests or release label Mar 4, 2020
@aliok
Copy link
Member

aliok commented Apr 10, 2020

/assign @aliok

@aliok
Copy link
Member

aliok commented Apr 10, 2020

We don't have these tests. I started working on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/channels area/test-and-release Test infrastructure, tests or release kind/feature-request proposal/0.13 Proposed (not planned) work items for 0.13 release
Projects
None yet
8 participants