Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Helpers should return the created resources #2011

Closed
Harwayne opened this issue Oct 8, 2019 · 2 comments
Closed

Test Helpers should return the created resources #2011

Harwayne opened this issue Oct 8, 2019 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone

Comments

@Harwayne
Copy link
Contributor

Harwayne commented Oct 8, 2019

We probably should return the created resource for every create function, to make them consistent, but can be in a different PR.

Originally posted by @chizhg in #1995


We have many functions in https://github.com/knative/eventing/blob/master/test/common/creation.go of the form CreateFooOrFail. Those functions should return the Foo that was created.

@chizhg
Copy link
Member

chizhg commented Jan 5, 2020

/assign

@chizhg chizhg removed their assignment Jul 6, 2020
@grantr grantr added this to the Backlog milestone Aug 24, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants