Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the webhook retry hack. #3681

Open
vaikas opened this issue Jul 22, 2020 · 9 comments
Open

Remove the webhook retry hack. #3681

vaikas opened this issue Jul 22, 2020 · 9 comments
Labels
area/api kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Issues which should be fixed (post-triage)
Milestone
Backlog

Comments

@vaikas
Copy link
Contributor

vaikas commented Jul 22, 2020

Describe the bug
As a workaround for
knative/pkg#1509

Added a retry for webhook failures. Once that's been fixed, remove the hackity hack.
@vaikas vaikas added the kind/bug Categorizes issue or PR as related to a bug. label Jul 22, 2020
pierDipi added a commit to pierDipi/eventing that referenced this issue Aug 3, 2020
@pierDipi
Do not fail when subscription already exists
a0a6f1f 
Recently we added a workaround for EOF errors:
knative#3681 and
some test seems to be flaky because
we try to create a subscription multiple times
when it already exists.
Some test runs show errors like this:
```
creation.go:175: Creating v1 subscription
creation.go:180: Failed to create subscription "<name>": conversion webhook for messaging.knative.dev/v1beta1, Kind=Subscription failed: Post https://eventing-webhook.knative-eventing-aw90d392a6.svc:443/resource-conversion?timeout=30s: EOF
creation.go:175: Creating v1 subscription <name> for channel &TypeMeta{Kind:InMemoryChannel,APIVersion:messaging.knative.dev/v1,}-e2e-singleevent-channel-structured
creation.go:180: Failed to create subscription "<name>": subscriptions.messaging.knative.dev "e2e-singleevent-subscription-structured" already exists
creation.go:185: Failed to create subscription "<name>": subscriptions.messaging.knative.dev "e2e-singleevent-subscription-structured" already exists
```
So, this PR adds a check for arleady exists errors to avoid
failing tests in those cases.

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi pierDipi mentioned this issue Aug 3, 2020
Merged
@grantr
Copy link
Contributor

grantr commented Aug 17, 2020

Blocked by knative/pkg#1509.

@grantr grantr added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/api priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed kind/bug Categorizes issue or PR as related to a bug. labels Aug 17, 2020
@grantr grantr added this to the Backlog milestone Aug 17, 2020
@grantr grantr mentioned this issue Oct 26, 2020
Closed
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 16, 2020
@pierDipi
Copy link
Member

/reopen

@knative-prow-robot
Copy link
Contributor

@pierDipi: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@pierDipi
Copy link
Member

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2021
@pierDipi pierDipi reopened this Aug 2, 2021
@pierDipi
Copy link
Member

pierDipi commented Aug 2, 2021

/triage accepted
/remove-lifecycle stale

@knative-prow-robot knative-prow-robot added triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 2, 2021
@vaikas vaikas removed their assignment Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@grantr @vaikas @pierDipi @knative-prow-robot