E2E test for broker tracing #1878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/L
daisy-ycguo
changed the title
knative-prow-robot
added
do-not-merge/work-in-progress
daisy-ycguo
force-pushed
the
broker-trace
branch
2 times, most recently
from
06d4b9d to
c5744fb
Compare
daisy-ycguo
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
daisy-ycguo
force-pushed
the
broker-trace
branch
from
c5744fb to
5cd9a97
Compare
Harwayne
added a commit
to Harwayne/knative-eventing
that referenced
this pull request
Sep 30, 2019
daisy-ycguo
force-pushed
the
broker-trace
branch
from
5cd9a97 to
f381ef2
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: daisy-ycguo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
daisy-ycguo
force-pushed
the
broker-trace
branch
4 times, most recently
from
9b5248a to
ec89a07
Compare
daisy-ycguo
force-pushed
the
broker-trace
branch
from
ec89a07 to
d66a29d
Compare
|
@daisy-ycguo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 9, 2019
* Copied verbatim from @daisy-ycguo's #1878. * Trace outline. * Add a hacky sleep so the Broker comes online. * Single trace! * Single place adds all the outgoing tracing. * Random * TestSpanTrace.Notes. * Small Changes. * In the right direction. * Close to working. * It works! * Remove debug logging. * 2 minutes. * Remove unneeded addition of the traceparent attribute. * Fix trace name unit test. * Improve comments. * Swtich the sleep to waiting for the Broker to be ready. * PR comments. * Rename to uri.go. * chose -> choose
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Oct 24, 2022
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1766
Proposed Changes
Release Note
NONE