Consistent and unique container names

[aliok]

Fixes #2794

Proposed Changes

• Change container names for consistency and uniqueness

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aliok
To complete the pull request process, please assign grantr
You can assign the PR to them by writing /assign @grantr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matzew]

/lgtm

/cc @vaikas

[n3wscott]

it should just be controller

[n3wscott]

controller

[n3wscott]

I don't like it.

I also do not like eventing's usage of non-standard container names but I want them all to be the same for the same purpose, not all unique.

/hold

[aliok]

@n3wscott

Eventing operator (and also serving operator) has a feature to override the images for containers that are created by the operator. It works like this:

apiVersion: operator.knative.dev/v1alpha1
kind: KnativeEventing
metadata:
...
spec:
  registry:
    override:
      eventing-controller: docker.io/my-eventing-controller

In this example, image for the container created with name eventing-controller is changed with docker.io/my-eventing-controller.

If all container names are not unique, this feature is not usable.

Otherwise, I don't care about the container names :D

but I want them all to be the same for the same purpose, not all unique.

Maybe we can come up with a proper naming strategy so that they're unique but still very similar as they have the same purpose?

[n3wscott]

I think the correct way to implement this in the operator is to use something like an obj ref with a path to know which controller this image override will be targeting. The current plan seems very fragile.

It is not the container name you are trying to find, it should be the deployment name + the container name + a namespace.

[aliok]

Fair enough. I think we found another way on our side to override images and I won't pursue this.

/close

[knative-prow-robot]

@aliok: Closed this PR.

In response to this:

Fair enough. I think we found another way on our side to override images and I won't pursue this.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.