Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix 3871 #3890

Closed
wants to merge 4 commits into from
Closed

[WIP] Fix 3871 #3890

wants to merge 4 commits into from

Conversation

aliok
Copy link
Member

@aliok aliok commented Aug 20, 2020

WIP to test a potential fix for #3871

@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 20, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 20, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Aug 20, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aliok
To complete the pull request process, please assign matzew
You can assign the PR to them by writing /assign @matzew in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok aliok changed the title [WIP] Fix nicholas pr [WIP] Fix 3871 Aug 20, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1alpha1/channelable_combined_types.go 93.3% 90.9% -2.4
pkg/apis/duck/v1alpha1/subscribable_types_conversion.go 89.3% 86.4% -2.8
pkg/reconciler/channel/channel.go 81.4% 77.4% -3.9

@aliok
Copy link
Member Author

aliok commented Aug 20, 2020

/close

Created nlopezgi#1

@knative-prow-robot
Copy link
Contributor

@aliok: Closed this PR.

In response to this:

/close

Created nlopezgi#1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aliok aliok deleted the fix_nicholas_pr branch April 28, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants