Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cluster.local to avoid issues with config validation webhook #872

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Oct 4, 2023

Changes

/assign @nak3

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2023
@nak3
Copy link
Contributor

nak3 commented Oct 4, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (97dab15) 82.14% compared to head (f9958a9) 82.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #872   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files          45       45           
  Lines        1725     1725           
=======================================
  Hits         1417     1417           
  Misses        266      266           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nak3
Copy link
Contributor

nak3 commented Oct 4, 2023

/override 'Downstream / Unit Test (knative/serving)'

@knative-prow
Copy link

knative-prow bot commented Oct 4, 2023

@nak3: nak3 unauthorized: /override is restricted to Repo administrators.

In response to this:

/override 'Downstream / Unit Test (knative/serving)'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsimansk
Copy link

dsimansk commented Oct 4, 2023

/override 'Downstream / Unit Test (knative/serving)'

@knative-prow
Copy link

knative-prow bot commented Oct 4, 2023

@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • 'Downstream
  • (knative/serving)'
  • /
  • Test
  • Unit

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • Unit Test (knative/serving)
  • build-tests_networking_main
  • integration-tests_networking_main
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • tide
  • unit-tests_networking_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override 'Downstream / Unit Test (knative/serving)'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsimansk
Copy link

dsimansk commented Oct 4, 2023

/override "Unit Test (knative/serving)"

@knative-prow
Copy link

knative-prow bot commented Oct 4, 2023

@dsimansk: Overrode contexts on behalf of dsimansk: Unit Test (knative/serving)

In response to this:

/override "Unit Test (knative/serving)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 53ba1f4 into knative:main Oct 4, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants