Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the combined operator instead of separated operator #121

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Use the combined operator instead of separated operator #121

merged 1 commit into from
Jun 3, 2020

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Jun 2, 2020 •
edited
Loading

Fixes #

Proposed Changes

  • This patch added the manifests of knative @ 0.15 into the kodata.
  • The net-istio is in a different version from knative serving. For simplicity, this PR removed the version_test.go fo yaml validation.
  • This PR installs combined operator for 0.14.x as the previous release for upgrade tests.
  • This PR updates the test cases to verify resources in 0.15.

Release Note

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 2, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 2, 2020
@houshengbo houshengbo force-pushed the combined-operator branch from c484568 to 1536300 Compare June 2, 2020 21:18
@houshengbo houshengbo changed the title Refactor the test cases and the test scripts Update the manifests into 0.15.0 and refactor the test scripts Jun 2, 2020
@houshengbo houshengbo changed the title Update the manifests into 0.15.0 and refactor the test scripts Update the manifests into 0.15.0 and refactor the test cases and scripts Jun 2, 2020
@houshengbo houshengbo force-pushed the combined-operator branch from 1536300 to dc7af9e Compare June 2, 2020 21:50
@houshengbo houshengbo changed the title Update the manifests into 0.15.0 and refactor the test cases and scripts Use the combined operator instead of separated operator Jun 2, 2020
evankanderson
evankanderson reviewed Jun 3, 2020
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [evankanderson,houshengbo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2020
@houshengbo houshengbo force-pushed the combined-operator branch from dc7af9e to aa6a076 Compare June 3, 2020 12:58
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 3, 2020
evankanderson
evankanderson reviewed Jun 3, 2020
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2020
@knative-prow-robot knative-prow-robot merged commit 8934009 into knative:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson left review comments

@aliok aliok Awaiting requested review from aliok

@jcrossley3 jcrossley3 Awaiting requested review from jcrossley3

Assignees

@evankanderson evankanderson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@houshengbo @knative-prow-robot @evankanderson @googlebot