Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more env vars for pingsource adapter env var preservation #1534

Merged

Conversation

aliok
Copy link
Member

@aliok aliok commented Aug 17, 2023

Fixes #

Proposed Changes

  • Add more env vars for pingsource adapter env var preservation
  • Without this, the eventing-controller and the operator are fighting to set env var values
  • Related to Env var changes of "pingsource-mt-adapter" are not respected #393
  • Ideally, we should find a way to fix this problem for good! Current solution is to maintain the env vars manually.

Release Note

Add more env vars for pingsource adapter env var preservation to prevent the eventing-controller and the operator fighting to set env var values.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 17, 2023
@knative-prow knative-prow bot requested review from matzew and maximilien August 17, 2023 07:59
Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliok: 0 warnings.

In response to this:

Fixes #

Proposed Changes

Release Note


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (72e396b) 79.10% compared to head (0542aa6) 79.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1534   +/-   ##
=======================================
  Coverage   79.10%   79.10%           
=======================================
  Files          40       40           
  Lines        1809     1809           
=======================================
  Hits         1431     1431           
  Misses        275      275           
  Partials      103      103           
Files Changed Coverage Δ
...knativeeventing/common/replicasenvvarstransform.go 70.58% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Aug 17, 2023

@aliok we might need backports?

@knative-prow knative-prow bot merged commit 80a2217 into knative:main Aug 17, 2023
@aliok
Copy link
Member Author

aliok commented Aug 17, 2023

@aliok we might need backports?

Yes, definitely. I am figuring out right now which branches to backport this.

We (RHAT) need it in 0.36.5, which is 1.9.5.

So, all the way to 1.9: 1.11, 1.10, 1.9

@aliok
Copy link
Member Author

aliok commented Aug 17, 2023

/cherrypick release-1.11

@knative-prow-robot
Copy link
Contributor

@aliok: new pull request created: #1535

In response to this:

/cherrypick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aliok aliok deleted the 2023-08-17-fix-pingsource-env-var-issue branch August 17, 2023 09:11
@aliok
Copy link
Member Author

aliok commented Aug 17, 2023

/cherrypick release-1.10

@aliok
Copy link
Member Author

aliok commented Aug 17, 2023

/cherrypick release-1.9

@knative-prow-robot
Copy link
Contributor

@aliok: new pull request created: #1537

In response to this:

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@aliok: new pull request created: #1538

In response to this:

/cherrypick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants