-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more env vars for pingsource adapter env var preservation #1534
Add more env vars for pingsource adapter env var preservation #1534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aliok: 0 warnings.
In response to this:
Fixes #
Proposed Changes
- Add more env vars for pingsource adapter env var preservation
- Related to Env var changes of "pingsource-mt-adapter" are not respected #393
- Ideally, we should find a way to fix this problem for good! Current solution is to maintain the env vars manually.
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
=======================================
Coverage 79.10% 79.10%
=======================================
Files 40 40
Lines 1809 1809
=======================================
Hits 1431 1431
Misses 275 275
Partials 103 103
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aliok we might need backports? |
Yes, definitely. I am figuring out right now which branches to backport this. We (RHAT) need it in 0.36.5, which is 1.9.5. So, all the way to 1.9: 1.11, 1.10, 1.9 |
/cherrypick release-1.11 |
@aliok: new pull request created: #1535 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.10 |
/cherrypick release-1.9 |
@aliok: new pull request created: #1537 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@aliok: new pull request created: #1538 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #
Proposed Changes
Release Note