Added Ports to NodePort service-types in knative-serving #1541

eBeyond · 2023-08-17T13:45:07Z

/lint

Proposed Changes

For the ServiceType NodePort it's now possible to add http-port and https-port. So the NodePorts of the service can be specified in the case that the standard isn't suitable.
Release Note

Added http-port and https-port for the ServiceType NodePort  (kourier config)

linux-foundation-easycla · 2023-08-17T13:45:10Z

The committers listed above are authorized under a signed CLA.

✅ login: eBeyond / name: Marc Ende (d5bb0d9, 3149c2d, 6b8e65f, f948a82, ed34fab)

knative-prow · 2023-08-17T13:45:15Z

Welcome @eBeyond! It looks like this is your first PR to knative/operator 🎉

knative-prow · 2023-08-17T13:45:17Z

Hi @eBeyond. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow

@eBeyond: 6 warnings.

In response to this:

/lint

Fixes #1523

Proposed Changes

For the ServiceType NodePort it's now possible to add http-port and https-port. So the NodePorts of the service can be specified in the case that the standard isn't suitable.
Release Note
Added http-port and https-port for the ServiceType NodePort  (kourier config)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow · 2023-08-17T13:45:18Z

pkg/apis/operator/base/ingressconfiguration.go

+	HttpPort int32 `json:"http-port,omitempty"`
+
+	// HttpsPort specifies the port used in case of ServiceType = "NodePort" for https (encrypted) traffic
+	HttpsPort int32 `json:"https-port,omitempty"`


Golint naming: struct field HttpsPort should be HTTPSPort. More info.

knative-prow · 2023-08-17T13:45:18Z

pkg/apis/operator/base/ingressconfiguration.go

@@ -41,6 +41,12 @@ type KourierIngressConfiguration struct {
 	// ServiceType specifies the service type for kourier gateway.
 	ServiceType v1.ServiceType `json:"service-type,omitempty"`

+	// HttpPort specifies the port used in case of ServiceType = "NodePort" for http traffic
+	HttpPort int32 `json:"http-port,omitempty"`


Golint naming: struct field HttpPort should be HTTPPort. More info.

knative-prow · 2023-08-17T13:45:18Z

pkg/reconciler/knativeserving/ingress/kourier_test.go

 				verifyBootstrapVolumeName(t, &u, tt.expConfigMapName)
 			}
 		})
 	}
 }

+func verifyGatewayServiceTypeNodePortHttp(t *testing.T, u *unstructured.Unstructured, expHttpPort int32) {


Golint naming: func parameter expHttpPort should be expHTTPPort. More info.

knative-prow · 2023-08-17T13:45:18Z

pkg/reconciler/knativeserving/ingress/kourier_test.go

+	}
+}
+
+func verifyGatewayServiceTypeNodePortHttps(t *testing.T, u *unstructured.Unstructured, expHttpsPort int32) {


Golint naming: func parameter expHttpsPort should be expHTTPSPort. More info.

knative-prow · 2023-08-17T13:45:18Z

pkg/reconciler/knativeserving/ingress/kourier_test.go

+		expNamespace      string
+		expServiceType    string
+		expConfigMapName  string
+		expNodePortsHttp  int32


Golint naming: struct field expNodePortsHttp should be expNodePortsHTTP. More info.

knative-prow · 2023-08-17T13:45:18Z

pkg/reconciler/knativeserving/ingress/kourier_test.go

+		expServiceType    string
+		expConfigMapName  string
+		expNodePortsHttp  int32
+		expNodePortsHttps int32


Golint naming: struct field expNodePortsHttps should be expNodePortsHTTPS. More info.

houshengbo · 2023-08-18T21:15:12Z

/ok-to-test

codecov · 2023-08-18T21:18:25Z

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% 🎉

Comparison is base (ce3949f) 79.10% compared to head (ed34fab) 79.25%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1541      +/-   ##
==========================================
+ Coverage   79.10%   79.25%   +0.14%     
==========================================
  Files          40       40              
  Lines        1809     1822      +13     
==========================================
+ Hits         1431     1444      +13     
  Misses        275      275              
  Partials      103      103

Files Changed	Coverage Δ
pkg/reconciler/knativeserving/ingress/kourier.go	`79.06% <100.00%> (+3.72%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

houshengbo · 2023-08-23T23:38:55Z

@eBeyond Plz fix all Golint naming issues.
You need to change the CRD as well, in order to add the fields.

…o CRD.

eBeyond · 2023-08-24T07:19:31Z

Changed the Http/Https to HTTP/HTTPS as requested by the linter.
Added the fields to the CRD

houshengbo · 2023-08-28T14:06:07Z

/test eventing-upgrade-tests

houshengbo

/lgtm
/approve

knative-prow · 2023-08-28T16:04:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eBeyond, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [houshengbo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Added Ports to NodePort service-types in knative-serving

d5bb0d9

knative-prow bot requested review from houshengbo and matzew August 17, 2023 13:45

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2023

knative-prow bot reviewed Aug 17, 2023

View reviewed changes

eBeyond mentioned this pull request Aug 17, 2023

The external Ports in kourier should be configurable. (change port/disable external ports) #1523

Closed

houshengbo removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2023

knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 18, 2023

fix: Linter requirements for uppercase HTTP and HTTPS. Added Fields t…

3149c2d

…o CRD.

eBeyond and others added 3 commits August 24, 2023 09:36

feat: Added check if field is set before assigning the ports.

6b8e65f

test: Added tests for 0 Http/Https NodePorts

f948a82

Merge branch 'knative:main' into main

ed34fab

houshengbo reviewed Aug 28, 2023

View reviewed changes

knative-prow bot assigned houshengbo Aug 28, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023

knative-prow bot merged commit c4e2316 into knative:main Aug 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Ports to NodePort service-types in knative-serving #1541

Added Ports to NodePort service-types in knative-serving #1541

eBeyond commented Aug 17, 2023

linux-foundation-easycla bot commented Aug 17, 2023 •

edited

Loading

knative-prow bot commented Aug 17, 2023

knative-prow bot commented Aug 17, 2023

knative-prow bot left a comment

knative-prow bot Aug 17, 2023

knative-prow bot Aug 17, 2023

knative-prow bot Aug 17, 2023

knative-prow bot Aug 17, 2023

knative-prow bot Aug 17, 2023

knative-prow bot Aug 17, 2023

houshengbo commented Aug 18, 2023

codecov bot commented Aug 18, 2023 •

edited

Loading

houshengbo commented Aug 23, 2023

eBeyond commented Aug 24, 2023

houshengbo commented Aug 28, 2023

houshengbo left a comment

knative-prow bot commented Aug 28, 2023

Added Ports to NodePort service-types in knative-serving #1541

Added Ports to NodePort service-types in knative-serving #1541

Conversation

eBeyond commented Aug 17, 2023

Proposed Changes

linux-foundation-easycla bot commented Aug 17, 2023 • edited Loading

knative-prow bot commented Aug 17, 2023

knative-prow bot commented Aug 17, 2023

knative-prow bot left a comment

Choose a reason for hiding this comment

Proposed Changes

knative-prow bot Aug 17, 2023

Choose a reason for hiding this comment

knative-prow bot Aug 17, 2023

Choose a reason for hiding this comment

knative-prow bot Aug 17, 2023

Choose a reason for hiding this comment

knative-prow bot Aug 17, 2023

Choose a reason for hiding this comment

knative-prow bot Aug 17, 2023

Choose a reason for hiding this comment

knative-prow bot Aug 17, 2023

Choose a reason for hiding this comment

houshengbo commented Aug 18, 2023

codecov bot commented Aug 18, 2023 • edited Loading

Codecov Report

houshengbo commented Aug 23, 2023

eBeyond commented Aug 24, 2023

houshengbo commented Aug 28, 2023

houshengbo left a comment

Choose a reason for hiding this comment

knative-prow bot commented Aug 28, 2023

linux-foundation-easycla bot commented Aug 17, 2023 •

edited

Loading

codecov bot commented Aug 18, 2023 •

edited

Loading