Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to manifestival 0.5.0 #16

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Conversation

jcrossley3
Copy link
Contributor

This is mostly to make Apply more robust to better handle strategic
patch creation involving certain merge keys: manifestival/manifestival#37

It also makes the None predicate a little less verbose

This is mostly to make Apply more robust to better handle strategic
patch creation involving certain merge keys:
manifestival/manifestival#37

It also makes the None predicate a little less verbose
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcrossley3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 13, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 13, 2020
@Cynocracy
Copy link

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2020
@knative-prow-robot knative-prow-robot merged commit e57069c into knative:master Apr 13, 2020
houshengbo pushed a commit to houshengbo/operator-2 that referenced this pull request Apr 16, 2020
* Update to manifestival 0.5.0

This is mostly to make Apply more robust to better handle strategic
patch creation involving certain merge keys:
manifestival/manifestival#37

It also makes the None predicate a little less verbose

* None predicate is variadic now, defaulting to Any
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants