Remove unnecessary KnativeServing code and finishing touches. #39
Conversation
knative-prow-robot
added
the
size/L
There was a problem hiding this comment.
@markusthoemmes: 0 warnings.
In response to this:
Proposed Changes
As the title stays. All the status update code in KnativeServing is redundant because it uses genreconciler which does all that out of the box.
Also a few last finishing touches.
Release Note
NONE/assign @houshengbo
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| logger := logging.FromContext(ctx) | ||
| ks.Status.InitializeConditions() |
There was a problem hiding this comment.
You sure we want to do this all the time? It's not going to overwrite anything important?
There was a problem hiding this comment.
Nope, serving's controllers do the same thing.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, jcrossley3, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Proposed Changes
As the title stays. All the status update code in KnativeServing is redundant because it uses genreconciler which does all that out of the box.
Also a few last finishing touches.
Release Note
/assign @houshengbo