Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from go dep to go mod to generate dependencies #41

Merged
merged 7 commits into from
Apr 29, 2020
Merged

Migrate from go dep to go mod to generate dependencies #41

merged 7 commits into from
Apr 29, 2020

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Apr 28, 2020 •
edited
Loading

Fixes #

Proposed Changes

  1. Run export GO111MODULE=on.
  2. Run go mod init knative.dev/operator.
  3. Create tools.go under hack.
  4. Run go mod tidy mutiple times, adding one line in replace section in go.mod file each time till we find them all.
  5. Run go mod vendor.
  6. Modify the file update-deps.sh under hack.
  7. Run ./hack/update-deps.sh.
  8. Remove Gopkg.lock and Gopkg.toml.

Release Note

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 28, 2020
knative-prow-robot
knative-prow-robot reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo: 1 warning.

In response to this:

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hack/tools.go

// This package imports things required by this repository, to force `go mod` to see them as dependencies
import (
_ "k8s.io/code-generator"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Golint imports: a blank import should be only in a main or test package, or have a comment justifying it.

aliok
aliok approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Gave it a try locally. It all looks good.

Let's fix the CLA problem and then we're good to go

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@houshengbo houshengbo added the cla: yes Indicates the PR's author has signed the CLA. label Apr 29, 2020
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes Indicates the PR's author has signed the CLA. label Apr 29, 2020
@houshengbo
Copy link
Contributor Author

/retest

@chaodaiG
Copy link

@googlebot rescan

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 29, 2020
@aliok
Copy link
Member

aliok commented Apr 29, 2020

/lgtm

Thanks @houshengbo .

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2020
@knative-prow-robot knative-prow-robot merged commit 0be1623 into knative:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@aliok aliok aliok approved these changes

@Cynocracy Cynocracy Awaiting requested review from Cynocracy

Assignees

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@houshengbo @knative-prow-robot @googlebot @chaodaiG @aliok