Eliminate the wasteful updates due to the aggregated rules #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcrossley3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
knative-prow-robot
added
the
size/L
jcrossley3
force-pushed
the
aggregated-rules
branch
from
697db26
to
a5ab852
Compare
For any ClusterRole with an aggregationRule, we read its rules from the database in the transformer, since the manifest will never contain the correct rules.
Could be an issue keeping labels/annotations around
jcrossley3
force-pushed
the
aggregated-rules
branch
from
95afd83
to
4876938
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
markusthoemmes
pushed a commit
to markusthoemmes/knative-operator
that referenced
this pull request
Sep 24, 2020
* 🍬 Adding 0.16.0 sugar controller Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * 🍰 Adding 0.16.1 sugar controller Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any
ClusterRolewith anaggregationRule, we read its rules from the database in the transformer, since the manifest will never contain the correct rules.