Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the resources field to the eventing CRD #51

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Add the resources field to the eventing CRD #51

merged 1 commit into from
Apr 30, 2020

Conversation

jcrossley3
Copy link
Contributor

Fixes #47

Release Note

Added a resources override field to the Eventing CRD

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 29, 2020
knative-prow-robot
knative-prow-robot reviewed Apr 29, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcrossley3: 0 warnings.

In response to this:

Fixes #47

Release Note

Added a resources override field to the Eventing CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/resources.go Do not exist 90.9%

@houshengbo
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, jcrossley3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [houshengbo,jcrossley3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 28cd45c into knative:master Apr 30, 2020
@matzew matzew mentioned this pull request Jun 16, 2020
Closed
markusthoemmes added a commit to markusthoemmes/knative-operator that referenced this pull request Sep 30, 2020
@markusthoemmes
Read images from environment in the upstream operator (knative#51)
b7a5c40 
* Read images from environment in the upstream operator

* Review: Renames, adding tests, short-circuits
markusthoemmes added a commit to markusthoemmes/knative-operator that referenced this pull request Oct 12, 2020
@markusthoemmes
Read images from environment in the upstream operator (knative#51) (k…
fc66484 
…native#52)

* Read images from environment in the upstream operator

* Review: Renames, adding tests, short-circuits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@matzew matzew Awaiting requested review from matzew

Assignees

@houshengbo houshengbo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resources override for eventing
5 participants
@jcrossley3 @knative-metrics-robot @houshengbo @knative-prow-robot @googlebot