-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an interface for common status mutations. #65
Add an interface for common status mutations. #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markusthoemmes: 0 warnings.
In response to this:
Proposed Changes
A big stepping stone towards reusable business logic: Unify the status of KnativeServing and Eventing in an interface.
Release Note
NONE
/assign @jcrossley3 @houshengbo
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/approve Looks great. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
0313bf4
to
a276bd9
Compare
Rebased! |
The following is the coverage report on the affected files.
|
/lgtm |
Proposed Changes
A big stepping stone towards reusable business logic: Unify the status of KnativeServing and Eventing in an interface.
Release Note
/assign @jcrossley3 @houshengbo