Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining KComponent interfaces and implementations. #66

Merged
merged 3 commits into from
May 7, 2020
Merged

Add remaining KComponent interfaces and implementations. #66

merged 3 commits into from
May 7, 2020

Conversation

markusthoemmes
Copy link
Contributor

Proposed Changes

As per title, this concludes the interface implementations and makes both types conform to the entire KComponent interface.

Release Note

NONE

/assign @aliok @houshengbo @jcrossley3

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2020
knative-prow-robot
knative-prow-robot reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusthoemmes: 0 warnings.

In response to this:

Proposed Changes

As per title, this concludes the interface implementations and makes both types conform to the entire KComponent interface.

Release Note

NONE

/assign @aliok @houshengbo @jcrossley3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markusthoemmes
Copy link
Contributor Author

/retest

I'd argue the coverage warning is benign.

jcrossley3
jcrossley3 reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@jcrossley3 jcrossley3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

pkg/apis/operator/v1alpha1/common.go Outdated
// KComponentSpec is a common interface for accessing the common spec of all known types.
type KComponentSpec interface {
// GetConfig returns means to override entries in upstream configmaps.
GetConfig() map[string]map[string]string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i think i'd like to typedef this to ConfigMapData just to clarify its purpose and reduce the noise.

pkg/apis/operator/v1alpha1/common.go Outdated
@@ -78,6 +101,21 @@ type CommonSpec struct {
Resources []ResourceRequirementsOverride `json:"resources,omitempty"`
}

// GetConfig implements KComponentSpec.
func (c *CommonSpec) GetConfig() map[string]map[string]string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ibid

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2020
@markusthoemmes
Copy link
Contributor Author

@jcrossley3 implemented your suggestion

@jcrossley3
Copy link
Contributor

/lgtm
/retest

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
@knative-prow-robot knative-prow-robot merged commit c83a20c into knative:master May 7, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/common.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/knativeeventing_types.go Do not exist 0.0%
pkg/apis/operator/v1alpha1/knativeserving_types.go Do not exist 0.0%
pkg/reconciler/common/config_maps.go Do not exist 85.0%

@knative-prow-robot
Copy link
Contributor

@markusthoemmes: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-sandbox-operator-go-coverage fe73318 link /test pull-knative-sandbox-operator-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@jcrossley3 jcrossley3 jcrossley3 left review comments

@Cynocracy Cynocracy Awaiting requested review from Cynocracy

@houshengbo houshengbo Awaiting requested review from houshengbo

Assignees

@jcrossley3 jcrossley3

@aliok aliok

@houshengbo houshengbo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@markusthoemmes @knative-prow-robot @jcrossley3 @knative-metrics-robot @aliok @houshengbo @googlebot