This repository has been archived by the owner on Jun 24, 2020. It is now read-only.
Add a comment about why cluster-admin is necessary. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately it appears that in order to use an aggregated clusterrole we need the operator to be a cluster-admin. This should help prevent confusion re: why we have both an explicit list and a blanket `*/*` granted to the operator service account.
|
/lgtm |
|
/assign @greghaynes (Is it normal to have separate LGTMer and approver? :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cynocracy, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately it appears that in order to use an aggregated
clusterrole we need the operator to be a cluster-admin.
This should help prevent confusion re: why we have both an
explicit list and a blanket
*/*granted to the operatorservice account.
See #282
Proposed Changes
Release Note
NONE