Fix the retry issue with deployment verification

[houshengbo]

Fixes #

Proposed Changes

• This PR fixed the broken retry mechanism, checking whether the deployments reach the desired state. It used to return false, err, which would run the check only once, but we need to return false, nil, till we reach the desired state. This PR made the correct changes for the retry mechanism.

Release Note

[knative-prow-robot]

@houshengbo: 0 warnings.

In response to this:

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [houshengbo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aliok]

@houshengbo
Can you give some details about this PR?
I think the code changes look fine, but just want to understand what the original problem was.

[houshengbo]

@aliok I added in the comments of the PR.

[aliok]

/lgtm

makes perfect sense 👍