Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test only] Test issuer changes in net-certmanager #14711

Closed
wants to merge 1 commit into from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Dec 6, 2023

Copy link

knative-prow bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2023
@knative-prow knative-prow bot requested review from kauana and krsna-m December 6, 2023 09:57
@skonto skonto added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49d1226) 86.04% compared to head (698e3f5) 86.08%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14711      +/-   ##
==========================================
+ Coverage   86.04%   86.08%   +0.04%     
==========================================
  Files         197      197              
  Lines       14937    14937              
==========================================
+ Hits        12853    12859       +6     
+ Misses       1774     1769       -5     
+ Partials      310      309       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor Author

skonto commented Dec 6, 2023

/retest

Copy link

knative-prow bot commented Dec 6, 2023

@skonto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
https_serving_main 698e3f5 link false /test https

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@skonto skonto closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant