From 97de6fdbe1124534c78a2d568cdcd3295eff3f17 Mon Sep 17 00:00:00 2001 From: Evan Anderson Date: Fri, 4 May 2018 19:05:00 +0000 Subject: [PATCH 1/2] Grant @elafros/elafros-maintainers CODEOWNERS over the entire repo. --- .github/CODEOWNERS | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 962b5d69c6c4..7e0527c0b6c6 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,41 +1,44 @@ ### KEEP THIS FIRST, LAST RULE WINS! # Default ownership until delegated -# * @evankanderson @mattmoor @vaikas-google +# * @elafros/elafros-maintainers # To allow automatic PR merging by prow, update any corresponding # OWNERS files in the relevant directories whenever CODEOWNERS is # updated. ### Component-level ownerships +# Note that **unlike Prow**, CODEOWNERS is not transitive. +# Include @elafros/elafros-maintainers on each line to allow the ToC +# to approve PRs if needed. # API governance. -/pkg/apis @evankanderson @mattmoor @vaikas-google +/pkg/apis @evankanderson @mattmoor @vaikas-google @elafros/elafros-maintainers # Build API (imported from elafros/build) -/pkg/apis/build @mattmoor @ImJasonH +/pkg/apis/build @mattmoor @ImJasonH @elafros/elafros-maintainers # API Core working group -/pkg/webhook @mattmoor @grantr @tcnghia -/pkg/controller @mattmoor @grantr @tcnghia +/pkg/webhook @mattmoor @grantr @tcnghia @elafros/elafros-maintainers +/pkg/controller @mattmoor @grantr @tcnghia @elafros/elafros-maintainers # All groups can review docs. -/docs/ @elafros/elafros-writers @google/elafros-readers +/docs/ @elafros/elafros-writers @google/elafros-readers @elafros/elafros-maintainers # Tests. -/test/ @adrcunha @srinivashegde86 @steuhs @bobcatfish -/test/conformance/ @bobcatfish @adrcunha +/test/ @adrcunha @srinivashegde86 @steuhs @bobcatfish @elafros/elafros-maintainers +/test/conformance/ @bobcatfish @adrcunha @elafros/elafros-maintainers # third_party -/third_party/ @evankanderson @mattmoor @vaikas-google @mdemirhan +/third_party/ @mdemirhan @elafros/elafros-maintainers # Scaling. -/cmd/ela-activator @josephburnett -/cmd/ela-autoscaler @josephburnett -/cmd/ela-queue/ @josephburnett -/pkg/activator @josephburnett -/pkg/autoscaler @josephburnett -/pkg/queue @josephburnett -/sample/autoscale @josephburnett +/cmd/ela-activator @josephburnett @elafros/elafros-maintainers +/cmd/ela-autoscaler @josephburnett @elafros/elafros-maintainers +/cmd/ela-queue/ @josephburnett @elafros/elafros-maintainers +/pkg/activator @josephburnett @elafros/elafros-maintainers +/pkg/autoscaler @josephburnett @elafros/elafros-maintainers +/pkg/queue @josephburnett @elafros/elafros-maintainers +/sample/autoscale @josephburnett @elafros/elafros-maintainers ### To request CODEOWNERS on a subdirectory, propose it above ### in a PR to the below maintainers. From 25587ee96752ec5020c463bab1af90d519209ef6 Mon Sep 17 00:00:00 2001 From: Evan Anderson Date: Fri, 4 May 2018 19:08:13 +0000 Subject: [PATCH 2/2] Clarify hierarchical, rather than transitive. --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 7e0527c0b6c6..492578b472db 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -7,7 +7,7 @@ # updated. ### Component-level ownerships -# Note that **unlike Prow**, CODEOWNERS is not transitive. +# Note that **unlike Prow OWNERS**, CODEOWNERS is not hierarchical. # Include @elafros/elafros-maintainers on each line to allow the ToC # to approve PRs if needed.