[Upbit] add support for market orders and candlestick #4823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aaron-jang
commented
Feb 11, 2024
aaron-jang
commented
- add support for market order (api doc en, kr)
- add support for candlestick (api doc en, kr)
bigscoop
reviewed
Feb 12, 2024
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import java.math.BigDecimal; | ||
|
|
||
| public class UpbitCandleStickData { |
There was a problem hiding this comment.
you can use lombok for boilerplate-code here
There was a problem hiding this comment.
@bigscoop Thanks for the suggestion! I've used Lombok to simplify the code.
|
Are there any more changes needed? If not, could you merge? Thanks! |
duplessisc
pushed a commit
to duplessisc/XChange
that referenced
this pull request
May 29, 2024
[Upbit] add support for market orders and candlestick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.