Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Edge Boxes if useHtmlLabels=false #541

Closed
renierr opened this issue Jun 14, 2017 · 5 comments
Closed

No Edge Boxes if useHtmlLabels=false #541

renierr opened this issue Jun 14, 2017 · 5 comments

Comments

@renierr
Copy link

renierr commented Jun 14, 2017

The Background Boxes are not rendered correct if html Labels are false.
Only the first one is shown, all other have no rect on edge labels.

@renierr
Copy link
Author

renierr commented Jun 14, 2017

The error is in:
var label = labels[i];

should be:
var label = labels[k];

@tylerlong
Copy link
Collaborator

Could you please reproduce the issue in https://mermaidjs.github.io/mermaid-live-editor/ and post back a link here?

And for the error report, did you create an issue? I don't know which file you talked about.

@renierr
Copy link
Author

renierr commented Mar 18, 2018

can not reproduce, its a long time ago.
And live editor does not seam to allow to set useHtmlLabels to false.

in file flowRenderer.js Line 459
ther is the wrong index var of the for loop

@tylerlong
Copy link
Collaborator

flowchart.htmlLabels by default is false. So mermaid live editor is also using a false value.

It is better if you can reproduce.

But I do see the code you pointed out, that code is very likely wrong. Nice catch.

@tylerlong
Copy link
Collaborator

Confirmed, the bug was introduced in ab398c6#diff-2d1e5c0548ca8417cc597b345f914aa2L513

Thanks!

mgenereu pushed a commit to mgenereu/mermaid that referenced this issue Jun 25, 2022
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.3 to 4.5.4.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.5.3...v4.5.4)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants