From 8fbb79b325bfd0a54bf3a846a16be9e4daec651a Mon Sep 17 00:00:00 2001 From: Raphael 'kena' Poss Date: Thu, 22 Nov 2018 16:46:07 +0100 Subject: [PATCH] sql: replace references to #8318 by #27792 Release note: None --- pkg/sql/parser/parse_test.go | 10 +++++----- pkg/sql/parser/sql.y | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/pkg/sql/parser/parse_test.go b/pkg/sql/parser/parse_test.go index 9c8a913ef823..f7bc9ef5e7e6 100644 --- a/pkg/sql/parser/parse_test.go +++ b/pkg/sql/parser/parse_test.go @@ -2639,7 +2639,7 @@ func TestUnimplementedSyntax(t *testing.T) { {`CREATE INDEX a ON b(c[d])`, 9682, ``}, {`CREATE INDEX a ON b(foo(c))`, 9682, ``}, - {`INSERT INTO foo(a, a.b) VALUES (1,2)`, 8318, ``}, + {`INSERT INTO foo(a, a.b) VALUES (1,2)`, 27792, ``}, {`INSERT INTO foo VALUES (1,2) ON CONFLICT ON CONSTRAINT a DO NOTHING`, 0, `on conflict on constraint`}, {`SELECT * FROM ab, LATERAL (SELECT * FROM kv)`, 24560, `select`}, @@ -2686,12 +2686,12 @@ func TestUnimplementedSyntax(t *testing.T) { {`WITH RECURSIVE a AS (TABLE b) SELECT c`, 21085, ``}, - {`UPDATE foo SET (a, a.b) = (1, 2)`, 8318, ``}, - {`UPDATE foo SET a.b = 1`, 8318, ``}, + {`UPDATE foo SET (a, a.b) = (1, 2)`, 27792, ``}, + {`UPDATE foo SET a.b = 1`, 27792, ``}, {`UPDATE foo SET x = y FROM a, b`, 7841, ``}, - {`UPDATE Foo SET x.y = z`, 8318, ``}, + {`UPDATE Foo SET x.y = z`, 27792, ``}, - {`UPSERT INTO foo(a, a.b) VALUES (1,2)`, 8318, ``}, + {`UPSERT INTO foo(a, a.b) VALUES (1,2)`, 27792, ``}, } for _, d := range testData { _, err := parser.Parse(d.sql) diff --git a/pkg/sql/parser/sql.y b/pkg/sql/parser/sql.y index b38d919e4129..268b0b178924 100644 --- a/pkg/sql/parser/sql.y +++ b/pkg/sql/parser/sql.y @@ -4980,10 +4980,10 @@ insert_column_list: // position. The rule below can be extended to support a sequence of // field subscript or array indexing operators to designate a part of // a field, when partial updates are to be supported. This likely will -// be needed together with support for compound types (#8318). +// be needed together with support for composite types (#27792). insert_column_item: column_name -| column_name '.' error { return unimplementedWithIssue(sqllex, 8318) } +| column_name '.' error { return unimplementedWithIssue(sqllex, 27792) } on_conflict: ON CONFLICT opt_conf_expr DO UPDATE SET set_clause_list where_clause @@ -5075,7 +5075,7 @@ single_set_clause: { $$.val = &tree.UpdateExpr{Names: tree.NameList{tree.Name($1)}, Expr: $3.expr()} } -| column_name '.' error { return unimplementedWithIssue(sqllex, 8318) } +| column_name '.' error { return unimplementedWithIssue(sqllex, 27792) } multiple_set_clause: '(' insert_column_list ')' '=' in_expr @@ -7022,7 +7022,7 @@ c_expr: // Currently we support array indexing (see c_expr above). // // TODO(knz/jordan): this is the rule that can be extended to support -// compound types (#8318) with e.g.: +// composite types (#27792) with e.g.: // // | '(' a_expr ')' field_access_ops //