don't fail plan when ko build fails #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <jason@chainguard.dev>
cpanato
approved these changes
Jun 8, 2024
mattmoor
reviewed
Jun 8, 2024
cpanato
reviewed
Jun 8, 2024
mattmoor
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding on #108
This prevents ko build failures of all kinds from blocking planning. It seems there may be cases where the
ko_buildin TF state is now invalid, and can't be updated because we never get to a successful create phase. Previously the most common example of this was that the importpath changed and the underlying directory was renamed -- this generalizes to handle all cases where the TF state's build is no longer valid but needs to get updated if we can build the new state.