Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump ggcr dependency, and cosign dep #77

Merged
merged 1 commit into from
May 23, 2023
Merged

bump ggcr dependency, and cosign dep #77

merged 1 commit into from
May 23, 2023

Conversation

imjasonh
Copy link
Member

Manual upgrade like #76

In addition to bumping ggcr, we also needed to bump cosign@main to pick up a fix for a breaking API change in ggcr:

# github.com/sigstore/cosign/v2/pkg/oci/remote
../../go/pkg/mod/github.com/sigstore/cosign/v2@v2.0.0/pkg/oci/remote/referrers.go:29:9: cannot use remote.Referrers(d, rOpt...) (value of type "github.com/google/go-containerregistry/pkg/v1".ImageIndex) as *"github.com/google/go-containerregistry/pkg/v1".IndexManifest value in return statement

This is fixed in this PR by go get -u github.com/sigstore/cosign/v2@main

@imjasonh
bump ggcr dependency, and cosign dep
326ab72 
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh requested a review from mattmoor May 23, 2023 13:44
@imjasonh imjasonh enabled auto-merge May 23, 2023 13:44
@imjasonh imjasonh mentioned this pull request May 23, 2023
Merged
@imjasonh imjasonh merged commit 17f0e88 into ko-build:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjasonh @mattmoor