-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin pyxform version with support for background-geopoint
questions
#5195
Closed
RuthShryock
wants to merge
12
commits into
main
from
backport-background-geopoint-question-to-pyxform
Closed
Pin pyxform version with support for background-geopoint
questions
#5195
RuthShryock
wants to merge
12
commits into
main
from
backport-background-geopoint-question-to-pyxform
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changes with upgrade
…L fixtures and test assertions to match the new format
…nt-question-to-pyxform
…round-geopoint-question-to-pyxform
…nt-question-to-pyxform
…eopoint-question-to-pyxform
jnm
force-pushed
the
backport-background-geopoint-question-to-pyxform
branch
from
November 7, 2024 05:01
9b1b11d
to
72e535f
Compare
jnm
changed the title
Pin pyxform version with backported support for
Pin pyxform version with support for Nov 7, 2024
background-geopoint
questionsbackground-geopoint
questions
After looking at this and the changes in pyxform v2.2.0, let's upgrade directly to that release. It'll make our lives easier in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
./python-format.sh
to make sure that your code lints and that you've followed our coding styleDescription
Support forms with
background-geopoint
questions which save background GPS location in surveys.Notes
Kpi is updated to support version 2.1.1 of pyxform. This version does not include recent support for
background-geopoint
questions so we are backporting this work into 2.1.1.Also note that this pr has a small fix for a missing
notify
import in the formbuilder.Testing
dev_requirements.txt
in your shell.background-geopoint
question. (Simple_background_geo.xlsx)