Bugfix: @inject was not resolving all arguments when used with kwargs #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s instead of compare lengths to avoid false positives when mixing @Inject with **kwargs Before it would just check the length of passed arguments vs the signature but that breaks down with **kwarg usage as you can hit cases where the number of passed arguments makes up for the arguments expected to be resolved by inject and then the resolve step is bypassed - leading to exceptions later.
|
@rspnijones Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a scenario where the inject failed, with this function signature:
@Inject
def _function(self,filename, perforce=None, **kwargs): #perforce is a registered with kink
and callsite:
self._function(filename, exportRoots=top_node, stripNamespaces=True)
The test if len(passed_kwargs) == len(parameters_name):
Returns true and bypasses resolving the services without actually testing if the supplied kwargs are the kwargs in the function.
Our bugfix updates that line to ensure the names agree so that we don't bypass the resolver sometimes.