fix: Ensure all variables are accessible in their local contexts. Closes

#302
kofrasa · Jan 12, 2023 · d2842bc · d2842bc
1 parent 1aa0556
commit d2842bc
Show file tree

Hide file tree

Showing 3 changed files with 135 additions and 3 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -5,7 +5,7 @@
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
     "sourceType": "module",
-    "project": "./tsconfig.eslint.json"
+    "project": "./tsconfig.lint.json"
   },
   "extends": [
     "eslint:recommended",

diff --git a/src/core.ts b/src/core.ts
@@ -151,7 +151,7 @@ export class ComputeOptions implements Options {
       ? options.update(
           // value can be '0' or 'false'
           isNil(options.root) ? root : options.root,
-          options.local || local
+          Object.assign({}, options.local, local)
         )
       : new ComputeOptions(options || initOptions(), root, local);
   }
@@ -482,6 +482,7 @@ export function computeValue(
         copts.local?.variables // local vars
       );
       const prefix = arr[0].slice(2);
+      console.log(context, copts);
       assert(
         has(context as RawObject, prefix),
         `Use of undefined variable: ${prefix}`

diff --git a/test/operators/expression/variable.test.ts b/test/operators/expression/variable.test.ts
@@ -1,6 +1,6 @@
 import "../../../src/init/system";
 
-import { aggregate } from "../../../src";
+import { aggregate, find } from "../../../src";
 
 describe("operators/expression/variable", () => {
   it("can apply $let operator", () => {
@@ -31,4 +31,135 @@ describe("operators/expression/variable", () => {
     expect(result[0].finalTotal).toEqual(9.450000000000001);
     expect(result[1].finalTotal).toEqual(10.25);
   });
+
+  // See: https://github.com/kofrasa/mingo/issues/302
+  it("can access all variables within defined scope", () => {
+    const docs = [
+      {
+        _id: "document1",
+        pattern: [
+          "string1",
+          [
+            "descriptor",
+            {
+              format: "longDate",
+              id: "1",
+            },
+          ],
+          "string2",
+          [
+            "descriptor",
+            {
+              format: "longDate",
+              id: "2",
+            },
+          ],
+          "string3",
+          [
+            "descriptor",
+            {
+              format: "longDate",
+              id: "3",
+            },
+          ],
+        ],
+      },
+      {
+        _id: "document2",
+        pattern: [
+          "string1",
+          [
+            "descriptor",
+            {
+              format: "longDate",
+              id: "4",
+            },
+          ],
+          "string2",
+          [
+            "descriptor",
+            {
+              format: "longDate",
+              id: "5",
+            },
+          ],
+          "string3",
+          [
+            "descriptor",
+            {
+              format: "longDate",
+              id: "6",
+            },
+          ],
+        ],
+      },
+    ];
+
+    const results = find(docs, {
+      $expr: {
+        $gt: [
+          {
+            $size: {
+              $filter: {
+                input: "$pattern",
+                as: "p",
+                cond: {
+                  $and: [
+                    {
+                      $isArray: ["$$p"],
+                    },
+                    {
+                      $let: {
+                        vars: {
+                          e: {
+                            $arrayElemAt: ["$$p", 1],
+                          },
+                        },
+                        in: {
+                          $eq: ["$$e.id", "1"],
+                        },
+                      },
+                    },
+                  ],
+                },
+              },
+            },
+          },
+          0,
+        ],
+      },
+    }).all();
+
+    expect(results).toEqual([
+      {
+        _id: "document1",
+        pattern: [
+          "string1",
+          [
+            "descriptor",
+            {
+              format: "longDate",
+              id: "1",
+            },
+          ],
+          "string2",
+          [
+            "descriptor",
+            {
+              format: "longDate",
+              id: "2",
+            },
+          ],
+          "string3",
+          [
+            "descriptor",
+            {
+              format: "longDate",
+              id: "3",
+            },
+          ],
+        ],
+      },
+    ]);
+  });
 });