Keep resources with ownerReference in stack prune #159
Conversation
|
any possibility to create some specs for these cases? |
Yeah, specs would be great. |
lib/k8s/stack.rb
Outdated
| @@ -101,6 +101,9 @@ def apply(client, prune: true) | |||
| if !server_resource | |||
| logger.info "Create resource #{resource.apiVersion}:#{resource.kind}/#{resource.metadata.name} in namespace #{resource.metadata.namespace} with checksum=#{resource.checksum}" | |||
| keep_resource! client.create_resource(prepare_resource(resource)) | |||
| elsif server_resource.metadata&.ownerReferences && !server_resource.metadata.ownerReferences.empty? | |||
| logger.info "Server resource #{server_resource.apiVersion}:#{server_resource.apiKind}/#{server_resource.metadata.name} in namespace #{server_resource.metadata.namespace} has an ownerReference and will be kept" | |||
| keep_resource! server_resource | |||
There was a problem hiding this comment.
hmm, I don't think this will work.
keep_resource! server_resource
will make @keep_resources map to have nil value for the "parsed" resource key. It'll later on fail at keep_resource? on return false unless keep_annotation as the keep_annotation will be nil
| @keep_resources["#{resource.kind}:#{resource.metadata.name}@#{resource.metadata.namespace}"] == resource.metadata&.annotations&.dig(@checksum_annotation) | ||
| keep_annotation = @keep_resources["#{resource.kind}:#{resource.metadata.name}@#{resource.metadata.namespace}"] | ||
| return false unless keep_annotation | ||
|
|
There was a problem hiding this comment.
I think we should check the owner reference count here before trying to check anything else. if there's owners, keep it.
There was a problem hiding this comment.
the keep_resource? won't be called when pruning with keep_resources: false (stack.delete / K8s::Stack.delete) (so implemented in the prune conditional monster)
|
Yeah seems like the "fix" is now in a branch that does not even get executed for extra server resources. The original fix in earlier commit was proper. |
Server resources with non-empty
metadata.ownerReferenceswill be left untouched during stack prune.(needs to be backported to v0.10)