Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added implementation of new webhook type #14

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

EduardDumitru
Copy link

@EduardDumitru EduardDumitru commented Dec 19, 2023

Motivation

Which issue does this fix? Fixes #issue number

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

@EduardDumitru EduardDumitru requested review from pokornyd and a team as code owners December 19, 2023 10:10
@pokornyd pokornyd self-assigned this Feb 12, 2024
@pokornyd
Copy link
Member

Hello Eduard, thank you for your PR submission. I'll review the proposed changes and get back to you with updates.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 33.72%. Comparing base (7101db3) to head (00c988b).
Report is 5 commits behind head on master.

Files Patch % Lines
...ore/Webhooks/Models/Legacy/DeliveryWebhookModel.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   34.21%   33.72%   -0.49%     
==========================================
  Files          10       11       +1     
  Lines         152      169      +17     
  Branches       12       12              
==========================================
+ Hits           52       57       +5     
- Misses        100      111      +11     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pokornyd pokornyd merged commit 0c90575 into kontent-ai:master Apr 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new webhook class
4 participants