Add web spotlight entity #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiriLojda
force-pushed
the
add_webSpotlight_entity
branch
from
3c405a0 to
69cf9d7
Compare
IvanKiral
requested changes
Aug 8, 2024
src/modules/importExport/importExportEntities/entities/webSpotlight.ts
Outdated
Show resolved
Hide resolved
| @@ -43,14 +43,17 @@ export const sync = async (client: ManagementClient, diff: DiffModel, logOptions | |||
| logInfo(logOptions, "standard", "Updating content types and adding their references"); | |||
| await updateContentTypesAndAddReferences(client, diff.contentTypes); | |||
|
|
|||
| logInfo(logOptions, "standard", "Updating web spotlight"); | |||
There was a problem hiding this comment.
I would add here comment, that the web_spotlight will use already existing type and never use the option to create one, that was added earlier :)
There was a problem hiding this comment.
I am not sure what you mean
There was a problem hiding this comment.
I mean explaining the order of these operations. As we first create all the types, when enabling Web Spotlight we don't have to worry that the type we are referencing won't exist. Due to this we always use the option when we provide the root_type parameter. We never use null when enabling Web Spotlight. Ideally, we would also update the diagram in the images :D
JiriLojda
force-pushed
the
add_webSpotlight_entity
branch
3 times, most recently
from
bc7027a to
e71dcbf
Compare
IvanKiral
requested changes
Aug 13, 2024
| @@ -21,6 +22,18 @@ export const spacesEntity: EntityDefinition<ReadonlyArray<SpaceContracts.ISpaceC | |||
| .withData({ | |||
| name: importSpace.name, | |||
| codename: importSpace.codename, | |||
| collections: importSpace.collections?.map(c => ({ | |||
| id: getRequired(context.collectionIdsByOldIds, c.id ?? "missing-collection-id", "collection"), | |||
There was a problem hiding this comment.
There is a comment on line 16 that should be removed
src/modules/sync/printDiff.ts
Outdated
|
|
||
| if (diffModel.webSpotlight.change !== "none") { | ||
| logInfo(logOptions, "standard", chalk.blue.bold("\nWEB SPOTLIGHT:")); | ||
| switch (diffModel.webSpotlight.change) { |
There was a problem hiding this comment.
const messsage = match(diffModel.webSpotlight)
.with({change: 'activate'} , ({rootTypeCodename}) => `Web Spotlight is to be activated with root type: ${chalk.green(rootTypeCodename)}`)
.with({change: "changeRootType"}, ({rootTypeCodename}) => `Web Spotlight root type is changed to: ${chalk.green(rootTypeCodename)}`)
.with({change: "deactivate"}, () => "Web Spotlight is to be deactivated")
.exhaustive();
logInfo(logOptions, "standard", messsage);
src/modules/sync/sync.ts
Outdated
| @@ -300,6 +303,21 @@ const transformTaxonomyOperations = ( | |||
| } as unknown as TaxonomyModels.IModifyTaxonomyData; | |||
| }; | |||
|
|
|||
| const updateWebSpotlight = (client: ManagementClient, diffModel: WebSpotlightDiffModel): Promise<unknown> => { | |||
There was a problem hiding this comment.
const updateWebSpotlight = (client: ManagementClient, diffModel: WebSpotlightDiffModel): Promise<unknown> =>
match(diffModel)
.with({ change: "none" }, () => Promise.resolve())
.with({ change: "deactivate" }, () => client.deactivateWebSpotlight().toPromise())
.with(
{ change: P.union("activate", "changeRootType") },
({ rootTypeCodename }) =>
client.activateWebSpotlight().withData({ root_type: { codename: rootTypeCodename } }).toPromise(),
)
.exhaustive();
JiriLojda
force-pushed
the
add_webSpotlight_entity
branch
2 times, most recently
from
b2ff989 to
1d6618c
Compare
IvanKiral
approved these changes
Aug 14, 2024
JiriLojda
force-pushed
the
add_webSpotlight_entity
branch
from
1d6618c to
af67c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?