Find right place for integration tests

[aufi]

There is a test/integration directory with tests working with multiple Konveyor components using the Hub API.

There might be some part of integration tests relevant for the Hub, but majority of such tests is more or less Konveyor application-level E2E testing that should likely be in a separate repository. The exact place is to be discussed&agreed.

Related resources:

• Hub Testing strategy #241
• Testing responsibilities enhancements#103
• Add CI testing overview enhancements#98

[aufi]

@dymurray @djzager The integration art of tests (with expected contribution from QE) should be moved from the Hub repo. Would you prefer something else than https://github.com/konveyor/go-konveyor-tests?

[dymurray]

@aufi I think go-konveyor-tests seems like the most appropriate place to me. Any objections?

[djzager]

why don't they live with the component being tested?

[djzager]

Looking at the comment that precipitated this issue, talking about the windup addon test not belonging in the hub. I believe the right answer is for the windup analysis integration test to live in the tackle2-addon-windup repo.

[aufi]

I'm for go-konveyor-tests repo too.

Reasons for separate repo (from my point of view)

• it tests/will test multiple components (even analyze test works with Hub+windup addon)
• it should be easier share the same test data for e.g. windup and lsp analyzer compatibility test
• it should cover more application level tests that already exist in separate repos e.g. for UI or the python-api suite (bad example, but it exists)
• and practical thing - QE should contribute to that repo, so have a separate one where they can merge tests each other without blocking/waiting for devs looks better for our future cooperation.

[djzager]

Am I missing something? The only test I see in the integration directory is a rewrite of the e2e test from the windup repo that was written in bash, now written in go...that we want to put into a 3rd repo.

[aufi]

The only test I see in the integration directory is a rewrite of the e2e test from the windup repo that was written in bash, now written in go...that we want to put into a 3rd repo.

That fits to my understanding, yes. The only existing rewritten test demonstrates that the integration works, but we're choosing a place for creating the test suite based on similar code as the existing test.

[aufi]

Analysis integration tests are continued in https://github.com/konveyor/go-konveyor-tests repository.