Skip to content

Commit

Permalink
Fix comments
Browse files Browse the repository at this point in the history
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
  • Loading branch information
avivtur authored and sjd78 committed Sep 6, 2023
1 parent 214cd74 commit c61ddce
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const ConfirmDeleteDialog: FC<ConfirmDeleteDialogProps> = ({
titleIconVariant={titleIconVariant}
isOpen={isOpen}
onClose={handleClose}
aria-label={t("Confirm delete dialog")}
aria-label="Confirm delete dialog"
actions={[confirmBtn, cancelBtn]}
title={t("dialog.title.delete", {
what: titleWhat,
Expand Down
4 changes: 1 addition & 3 deletions client/src/app/components/ConfirmDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export interface ConfirmDialogProps {
cancelBtnLabel: string;

inProgress?: boolean;
submitDisabled?: boolean;
confirmBtnVariant: ButtonVariant;

onClose: () => void;
Expand All @@ -38,7 +37,6 @@ export const ConfirmDialog: React.FC<ConfirmDialogProps> = ({
confirmBtnLabel,
cancelBtnLabel,
inProgress,
submitDisabled,
confirmBtnVariant,
onClose,
onConfirm,
Expand All @@ -50,7 +48,7 @@ export const ConfirmDialog: React.FC<ConfirmDialogProps> = ({
key="confirm"
aria-label="confirm"
variant={confirmBtnVariant}
isDisabled={submitDisabled || inProgress}
isDisabled={inProgress}
onClick={onConfirm}
>
{confirmBtnLabel}
Expand Down

0 comments on commit c61ddce

Please sign in to comment.