Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to use latest Rust build system and build dependencies #7

Closed
wants to merge 1 commit into from
Closed

Conversation

benanders
Copy link

I didn't download the lodepng source in the build.rs file like the previous Makefile did. I just added the source into the src folder.

@kornelski
Copy link
Owner

Sorry, but I'm not fond of duplicating other code in the repository.

I think change of Makefiles to barebones Rust-based build is a change for worse:

rust-lang/cargo#610 (comment)
rust-lang/cargo#887

@benanders
Copy link
Author

No problem. I did this more for myself, just so I could use the bindings in my own project without rewriting it, and have it compile nicely with Cargo. Thought I'd submit a pull request just in case.

@kornelski kornelski closed this Jul 2, 2015
@0xcpu 0xcpu mentioned this pull request Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants