Regression: confirm_os_window_close=x stopped to work

[Felixoid]

Describe the bug
The setting is ignored and window/tab is closed silently

To Reproduce
Steps to reproduce the behavior:

1. kitty --config NONE -o confirm_os_window_close=1
2. Open a few more windows and tabs
3. Try to close a tab with few windows, it's closed w/o confirmation
4. Try to close an OS window with few tabs, it's closed too

Environment details

kitty 0.23.1 (8397970bf8) created by Kovid Goyal
Linux felix-lm 5.13.9-arch1-1 #1 SMP PREEMPT Sun, 08 Aug 2021 11:25:35 +0000 x86_64
Arch Linux \r (\l)
Running under:X11
Loaded config overrides:
  confirm_os_window_close 1

Config options different from defaults:
confirm_os_window_close 1

[kovidgoyal]

Works for me. Note that if you are running from master, it will ignore
windows that are sitting at a prompt.

[Felixoid]

Here's a screencast of a mentioned behavior

vokoscreenNG-2021-08-20_11-04-32.mov

vokoscreenNG-2021-08-20_11-04-32.tar.gz

[kovidgoyal]

Those are all windows sitting at prompts.

[Felixoid]

Ok, it seems I didn't get your idea. But how can I now prevent the terminal from unsafe closing the tab or window?

https://sw.kovidgoyal.net/kitty/conf/#opt-kitty.confirm_os_window_close does this documentation misleading now?

[kovidgoyal]

On Fri, Aug 20, 2021 at 03:57:22AM -0700, Mikhail f. Shiryaev wrote: Ok, it seems I didn't get your idea. But how can I now prevent the terminal from unsafe closing the tab or window?

You dont need to do anything: 5bc569c

https://sw.kovidgoyal.net/kitty/conf/#opt-kitty.confirm_os_window_close does this documentation misleading now?

The documentation refers to the released version, it will change when the next version is released.

[Felixoid]

Oh, thanks. It works now