merge code to newest #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has sleep race Summary: transfer_log_lock_test.sh is redundant with wdt_lock_failfast.sh and has sleep race so let's delete the one with sleep and use the one with -fork which always (should) work Reviewed By: uddipta Differential Revision: D3526129 fbshipit-source-id: ff4fe3eaf6682cefacd5e633a574b351fcb748f5
Summary: wdt version bump auto commit fbshipit-source-id: 38c5e51d818645a55f7cae4f5266b90ca47ef3d1
Summary: wdt version bump auto commit fbshipit-source-id: 5593abd6bb39c3ba81a547385c778f70e3f45794
Summary: For unit testing stargate, we need to be able to remove WDT object for an app Reviewed By: ldemailly Differential Revision: D3554004 fbshipit-source-id: eb8261bd9732916273086254bcfe8a0a9deab0e5
Summary: wdt version bump auto commit fbshipit-source-id: afd5faec7ff71b96ec0a33dcba53bb429ed6a66d
Summary: Adding a mode of stargate where we try to minimize cross region data transfer. For this, hosts in the same region elect one host to download data cross region. It is then distributed to other hosts using WDT. Reviewed By: ldemailly Differential Revision: D3542052 fbshipit-source-id: 6fe4cf828c7cc4f7da3f9efd64b14e970c522b2a
Summary: Add wdtReceiveAsync on wdt as wdtSend already exists. It's follow up diff on D3515823. Reviewed By: uddipta Differential Revision: D3532271 fbshipit-source-id: efb2ae6fa9ecabb80f97ae04c6518e68123fad76
…d EVP_CIPHER_CTX in fbcode Summary: Fixed remaining cases of stack-allocated or class/struct member EVP_CIPHER_CTX structures, since that won't work in OpenSSL 1.1.0+. Clang-format-diff.py is responsible for a lot of the whitespace changes. Reviewed By: knekritz Differential Revision: D3707470 fbshipit-source-id: e36a99756ab84bbe32812be9791a6e692da72deb
Summary: See title. Apparently my changes are causing crashes. Reviewed By: uddipta Differential Revision: D3752985 fbshipit-source-id: 71fff8d3252b10fcc1bd52faefe30c81de31ed5f
…working Summary: Global sender and receiver limit configuration through gflag was not working. Resource controller was getting created before options were updated from flags. Reviewed By: ldemailly Differential Revision: D3789161 fbshipit-source-id: c7acb805273c59e8e63f2f38d0a4a4ef053de39a
Summary: Closes #129 Differential Revision: D3793113 Pulled By: ldemailly fbshipit-source-id: 97b2cfa945e596daa09dfc576fb8549a8c7957a9
Summary: also show stargate history in build email because we now also run extended stargate tests which can break Reviewed By: uddipta Differential Revision: D3792218 fbshipit-source-id: 147b696e75d47d7bb810d00b0c4349939c13ac28
Summary: fixing test failing because options of timeout test impacted other test Reviewed By: uddipta Differential Revision: D3794716 fbshipit-source-id: c7b8cfd8a23cfafa346477b4a9421090ac4ccbcb
Summary: This codemods `TARGETS` under `[a-d]*` directories in fbcode to make the `headers` parameter explicitly refer to `AutoHeaders.RECURSIVE_GLOB`. Reviewed By: yfeldblum Differential Revision: D3801845 fbshipit-source-id: 715c753b6d4ca3a9779db1ff0a0e6632c56c0655
Summary: Fix code that is transitively including ScopeGuard.h via FBString.h. Reviewed By: yfeldblum Differential Revision: D3801328 fbshipit-source-id: 7e1dc37cd6dd3aa691dd1baf31385d3a8c51eed0
Summary: wdt version bump auto commit fbshipit-source-id: 43816469871a356c8d184038d15b884f0306d8cd
Summary: auto version bump was failing because hg pull decided to start sending stuff to stderr ( https://www.facebook.com/groups/sourcecontrol/permalink/1075501102499509/ ) this fixes that Reviewed By: hehe-wz Differential Revision: D3815710 fbshipit-source-id: b3842ed9d03e871e67d87cb1c4f97117f2b4e10d
Summary: wdt version bump auto commit fbshipit-source-id: bb80d8cee7d80cf3dc62d01a4a5ff09cd271f45a
Summary: sync repo hashes fbshipit-source-id: e6bfdc30ee5b0d0242f8c4f3a35bc2bb6cac2021 Test Plan: n/a Reviewers: Subscribers: Tasks: Blame Revision:
Summary: wdt version bump auto commit fbshipit-source-id: 3219116d44d9afa810a64f0bafc257909e279dc4
Summary: 1) version update script for stargate 2) auto version upgrade in case of successful build Reviewed By: ldemailly Differential Revision: D3851015 fbshipit-source-id: 3a7cd014f7ee1fe1520d44121c8f133f23b577f4
Summary: wdt/stargate version bump auto commit fbshipit-source-id: 989d142469ac5a8e07d70bf650dca45c521944f0
Summary: fixing stargate tests leaking space in dev/shm also use hg log from either stargate or wdt to generate auto version Reviewed By: uddipta Differential Revision: D3857948 fbshipit-source-id: 6d1e355066e083d10b5533306dde1777f5b44a60
Summary: WDT throttler rate can now be lowered in the middle of a transfer. We reset throttler state in case rate changes Reviewed By: ldemailly Differential Revision: D3860371 fbshipit-source-id: f19b3ce772cc1f85065bfa9e9ec6bb5757807f6a
Summary: wdt/stargate version bump auto commit fbshipit-source-id: 54c480e0ba965e62b54dbed3ecb1a1eb134e4833
Summary: Reducing throttler rate in test so that it passes with asan Reviewed By: ldemailly Differential Revision: D3861060 fbshipit-source-id: f575fe636f90b4781fd1c3388cb31a5bd3c1a502
Summary: wdt/stargate version bump auto commit fbshipit-source-id: 233bc23e43cc75096ead6815d883ab9f836783b4
Summary: Server-id as second key for sender in WDT resource controller. Reviewed By: ldemailly Differential Revision: D3880699 fbshipit-source-id: 416df541cc4dfba37e487f90c97262e9f64a4cc0
Summary: `folly::cold_detail::ColdClass` was marking things (like `folly::Unexpected`) cold, but at the cost of inhibiting the inliner from doing its job. This is leading to bad codegen, which offsets any small wins we mind get for the `cold` attribute. Reviewed By: yfeldblum Differential Revision: D19324159 fbshipit-source-id: 7ed431b6c9d6e963c3bf438c707fa6cf6a38bf9d
Summary: We experimented with enabling DirectIO within FileWriter but the logic became a bit too complex. The primary goal was to reduce page cache pollution from files being downloaded if they are not needed immediately. An alternative approach is to fadvise the cached blocks away periodically following syncs. Here we add a fadvise call with FAD_DONTNEED immediately following the call to `sync_file_range` to inform the kernel that the corresponding pages may be dropped immediately. This call is conditioned on a new flag added to WdtOptions. Reviewed By: gwicke Differential Revision: D19606983 fbshipit-source-id: 2d12639d8c523edd679161990d8c91ea8d212d18
Summary: Stupid bug. Should return `false` in case of `fadvise` error. Replacing the error code enum with boolean. Differential Revision: D19730619 fbshipit-source-id: dfe6b2dc4e5be0b6d157e232a5f26cf530d602d6
Summary:
1. add a new init method for WDT, where users can pass in a whitelist of identities when initializing WDT service
2. plug in a logic in WDT server so that it verifies the caller's identity, and only callers with allowed identity ("laser_db_leaf") can get permission to download data from peer
Differential Revision: D21887094
fbshipit-source-id: c78f4f045985421b80485ac681c70e9fedfe337e
fbshipit-source-id: 5113fe0c527595e4227ff827253b7414abbdf7ac
fbshipit-source-id: 798decc90db4f13770e97cdce3c0df7d5421b2a3
Summary: It's dominating the logs. Differential Revision: D23063896 fbshipit-source-id: d8ffbee1a18edf69db8a8afcc993c6e58aecbfe0
Summary: Context: https://fb.workplace.com/groups/lasereng/permalink/3555830174428424/ Reviewed By: lujcmss Differential Revision: D23488492 fbshipit-source-id: 89cf8887245019094123ff973d62e3cf60520cda
Summary: addressing feedback from https://www.internalfb.com/intern/diff/D23063896 (https://github.com/facebook/wdt/commit/51dd64982051475571acc7874d556f54f2b36173)/?transaction_id=1211402319222670 Original commit changeset: d8ffbee1a18e Differential Revision: D23605056 fbshipit-source-id: b8b5703e616819833fb38de9aebaeffa6c030b3b
Summary: Fixed typo functionality Pull Request resolved: #207 Differential Revision: D24874427 Pulled By: davide125 fbshipit-source-id: 17fbdfbdd3e506629fab7a5b7ece8db590afdaef
Summary: env:`USER` is not available in docker so use the python inbuilt getpass to try all available methods to get username. Pull Request resolved: #190 Reviewed By: claudiozz Differential Revision: D24872834 Pulled By: davide125 fbshipit-source-id: be1a308ffa47e041009c6eca2268d15ba8001d7e
Summary: Without this, the compilation fails with : wdt/test/EncryptionTest.cpp:76:57: error: no matching function for call to 'find(std::vector<std::__cxx11::basic_string<char> >::iterator, std::vector<std::__cxx11::basic_string<char> >::iterator, std::string&)' Signed-off-by: Nicolas Chauvet <kwizart@gmail.com> Pull Request resolved: #210 Reviewed By: claudiozz Differential Revision: D24869824 Pulled By: davide125 fbshipit-source-id: 78777f76f0bee7f3fd9d0d6362d7673b9f7c0f13
Summary: This is the method to integrate Gtest described in their docs here https://github.com/google/googletest/blob/master/googletest/README.md. Before integrating this I could not build on Xcode or Makefiles on macOS. Pull Request resolved: #188 Reviewed By: claudiozz Differential Revision: D24890600 Pulled By: davide125 fbshipit-source-id: ae3f8d6eee5cfe4190e1b6b424bb4b8098f74c38
Summary: GFlags 2.1.1 is what is available without rebuilding on CentOS 7. This patch to the CMake makes sure we can always build with gflags < 2.2.0. Pull Request resolved: #191 Reviewed By: michel-slm Differential Revision: D24900188 Pulled By: davide125 fbshipit-source-id: cb1fbf604473192b8ae446ff9686811b79c1b813
Summary: Pull Request resolved: #195 Reviewed By: filbranden Differential Revision: D24907319 Pulled By: davide125 fbshipit-source-id: e590df2cea6f71166a90fa71a99e5555e30e9dad
Summary: Pull Request resolved: #201 Reviewed By: filbranden Differential Revision: D24924059 Pulled By: davide125 fbshipit-source-id: 50acaa1a34f4bc8d25a9eff432706af14931220e
Summary: These changes fix Travis-CI builds on macOS and partially on Linux. The only thing left to do on Linux is #192 This pull request also requires #188 Pull Request resolved: #193 Reviewed By: claudiozz Differential Revision: D24933398 Pulled By: davide125 fbshipit-source-id: eb96db30a3cb71695111a7d41ca2c27fbe891d87
Summary: Use a system gtest if one is available Reviewed By: filbranden Differential Revision: D25059075 fbshipit-source-id: 46ebfb1298529bbf3ada22e31f2ce19413c38852
Summary: [Folly] Cut `FOLLY_HAVE_MEMRCHR` since it is now unused. Reviewed By: Orvid Differential Revision: D22130149 fbshipit-source-id: b10c5a52354f5c549d96b54e0c165f08b96612b1
Summary: Update and fix Python tests Reviewed By: michel-slm Differential Revision: D26033500 fbshipit-source-id: 757e5c44b0d8c467127fcb60340f4312b14a7a4a
Summary: To identify ABI breaks and make this easier to package Reviewed By: michel-slm Differential Revision: D26127827 fbshipit-source-id: 2b611ef7282e0c94399b5f72dcc23663667ee4e6
Reviewed By: igorsugak Differential Revision: D27006737 fbshipit-source-id: b6278159eff56a4d8657ce505b616a1812addb86
Summary: C++17 permits use of `std::unique_lock` instead of `folly::SpinLockGuard`; just use that. C++11 permits use of `std::unique_lock<SpinLock>`. Differential Revision: D27390136 fbshipit-source-id: bcc34a043644289523ddfdfbf47a260c133db186
Summary: Per D27390136 (fdbc543) / fdbc543, WDT requires C++17 to build (for the refactor replacing `folly::SpinLockGuard` with `std::unique_lock`). Bump the language standard declared in `CMakeLists.txt` so public builds can succeed. Reviewed By: davide125 Differential Revision: D27867115 fbshipit-source-id: 38e9237d31b3750647279e9a5e227249923406f5
Summary: Facebook no longer recommends using patent grants for open source projects; bring this project in alignment. Brought up during the Fedora review back in March: https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/2AVHXQD3 (https://github.com/facebook/wdt/commit/a38ef09636bfc4ea4e49d0f38ee8f3e17edc4841)C2JBSZQT7E6HK3HHQ4O5KBDV/ Reviewed By: davide125 Differential Revision: D29374358 fbshipit-source-id: 39552b102286a558ed68e2684a8e3616d062defa
Summary: Fix TSAN issue due to std::chrono non atomic access Reviewed By: danobi Differential Revision: D29903190 fbshipit-source-id: 31c574741542cc6303d01b42a74ef5d30ebc7e04
Reviewed By: biran0079 Differential Revision: D30011604 fbshipit-source-id: 7d3f52cde6cbf9abc27b8b4954df990bbd7a58e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge code to newest state.