Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lutris game never finishes import #270

Closed
portalbyte opened this issue Jun 21, 2024 · 3 comments · Fixed by #301
Closed

Lutris game never finishes import #270

portalbyte opened this issue Jun 21, 2024 · 3 comments · Fixed by #301
Labels
bug Something isn't working

Comments

@portalbyte
Copy link

Describe the bug
If I create a new game via Lutris (Flatpak) & press the "import" button in Cartridges, it will never dismiss the 'importing games' dialog box, and never finish importing the game via the console (although it does get added to the grid). This does not occur with Steam.

To Reproduce
Steps to reproduce the behavior:

  1. Add a game via Lutris (Flatpak).
  2. Open Cartridges.
  3. Press "Import"

Expected behavior
The game should be added to the grid, and the dialog box should disappear.

Screenshots
Screencast from 2024-06-21 16-37-50.webm

Logs

32:05 - DEBUG: Starting page.kramo.Cartridges v2.8.5 (release)
32:05 - DEBUG: Python version: 3.11.9 (main, Nov 10 2011, 15:00:00) [GCC 13.2.0]
32:05 - DEBUG: Flatpak version: Flatpak 1.15.8
32:05 - DEBUG: Platform: Linux-6.9.5-zen1-1-zen-x86_64-with-glibc2.38
32:05 - DEBUG: 	System: Linux
32:05 - DEBUG: 	Node: glados
32:05 - DEBUG: 	Release: 6.9.5-zen1-1-zen
32:05 - DEBUG: 	Version: #1 ZEN SMP PREEMPT_DYNAMIC Sun, 16 Jun 2024 19:06:18 +0000
32:05 - DEBUG: 	Machine: x86_64
32:05 - DEBUG: 	Processor: 
32:05 - DEBUG: ─────────────────────────────────────
32:05 - DEBUG: New store game Prism Launcher (flatpak_org.prismlauncher.PrismLauncher)
32:06 - DEBUG: DisplayManager done for flatpak_org.prismlauncher.PrismLauncher
32:06 - DEBUG: New store game War Thunder (steam_236390)
32:06 - DEBUG: DisplayManager done for steam_236390
32:06 - DEBUG: New store game Songs of Conquest (lutris_wine_1)
32:06 - DEBUG: DisplayManager done for lutris_wine_1
32:06 - DEBUG: New store game Subnautica (lutris_wine_2)
32:06 - DEBUG: DisplayManager done for lutris_wine_2
32:06 - DEBUG: New store game Euro Truck Simulator 2 (lutris_wine_3)
32:06 - DEBUG: DisplayManager done for lutris_wine_3
32:06 - DEBUG: New store game Kerbal Space Program (steam_220200)
32:06 - DEBUG: DisplayManager done for steam_220200
32:06 - DEBUG: New store game Subnautica: Below Zero (lutris_wine_4)
32:06 - DEBUG: DisplayManager done for lutris_wine_4
32:11 - DEBUG: Importing games from source legendary
32:11 - DEBUG: Importing games from source steam
32:11 - DEBUG: Importing games from source heroic
32:11 - DEBUG: Importing games from source itch
32:11 - DEBUG: Importing games from source desktop
32:11 - INFO: Source legendary skipped, bad location
32:11 - INFO: Source heroic skipped, bad location
32:11 - DEBUG: Importing games from source lutris
32:11 - DEBUG: Importing games from source flatpak
32:11 - DEBUG: Importing games from source retroarch
32:11 - INFO: Source itch skipped, bad location
32:11 - DEBUG: Importing games from source bottles
32:11 - INFO: Scanning source desktop
32:11 - INFO: Source retroarch skipped, bad location
32:11 - DEBUG: Import done for source legendary
32:11 - DEBUG: Import done for source heroic
32:11 - DEBUG: Import done for source itch
32:11 - DEBUG: Import done for source retroarch
32:11 - DEBUG: Resolved value for schema key steam-location: /home/portalbyte/.var/app/com.valvesoftware.Steam/data/Steam
32:11 - INFO: Scanning source steam
32:11 - DEBUG: Resolved value for schema key flatpak-system-location: /var/lib/flatpak
32:11 - INFO: Scanning source flatpak
32:11 - DEBUG: New store game Kerbal Space Program (steam_220200) (replacing a removed one)
32:11 - INFO: Imported Kerbal Space Program (steam_220200)
32:11 - DEBUG: Duplicate store game War Thunder (steam_236390)
32:11 - DEBUG: Import done for source steam
32:11 - DEBUG: Resolved value for schema key bottles-location: /home/portalbyte/.var/app/com.usebottles.bottles/data/bottles
32:11 - INFO: Scanning source bottles
32:11 - DEBUG: Import done for source bottles
32:11 - DEBUG: Resolved value for schema key lutris-location: /home/portalbyte/.var/app/net.lutris.Lutris/data/lutris
32:11 - INFO: Scanning source lutris
32:11 - DEBUG: Starting new HTTPS connection (1): store.steampowered.com:443
32:11 - DEBUG: Duplicate store game Songs of Conquest (lutris_wine_1)
32:11 - DEBUG: Duplicate store game Subnautica (lutris_wine_2)
32:11 - DEBUG: Duplicate store game Euro Truck Simulator 2 (lutris_wine_3)
32:11 - DEBUG: Duplicate store game Subnautica: Below Zero (lutris_wine_4)
32:11 - DEBUG: Import done for source lutris
32:11 - DEBUG: Duplicate store game Prism Launcher (flatpak_org.prismlauncher.PrismLauncher)
32:11 - DEBUG: Import done for source flatpak
32:11 - DEBUG: Import done for source desktop
32:12 - DEBUG: https://store.steampowered.com:443 "GET /api/appdetails?appids=220200 HTTP/1.1" 200 3550
32:12 - DEBUG: SteamAPIManager done for steam_220200
32:12 - DEBUG: CoverManager done for steam_220200
32:12 - DEBUG: FileManager done for steam_220200
32:12 - DEBUG: SgdbManager done for steam_220200
32:12 - DEBUG: DisplayManager done for steam_220200
32:12 - INFO: Import done
─────────────────────────────────────
37:40 - DEBUG: Starting page.kramo.Cartridges v2.8.5 (release)
37:40 - DEBUG: Python version: 3.11.9 (main, Nov 10 2011, 15:00:00) [GCC 13.2.0]
37:40 - DEBUG: Flatpak version: Flatpak 1.15.8
37:40 - DEBUG: Platform: Linux-6.9.5-zen1-1-zen-x86_64-with-glibc2.38
37:40 - DEBUG: 	System: Linux
37:40 - DEBUG: 	Node: glados
37:40 - DEBUG: 	Release: 6.9.5-zen1-1-zen
37:40 - DEBUG: 	Version: #1 ZEN SMP PREEMPT_DYNAMIC Sun, 16 Jun 2024 19:06:18 +0000
37:40 - DEBUG: 	Machine: x86_64
37:40 - DEBUG: 	Processor: 
37:40 - DEBUG: ─────────────────────────────────────
37:40 - DEBUG: New store game Prism Launcher (flatpak_org.prismlauncher.PrismLauncher)
37:40 - DEBUG: DisplayManager done for flatpak_org.prismlauncher.PrismLauncher
37:40 - DEBUG: New store game War Thunder (steam_236390)
37:40 - DEBUG: DisplayManager done for steam_236390
37:40 - DEBUG: New store game Songs of Conquest (lutris_wine_1)
37:40 - DEBUG: DisplayManager done for lutris_wine_1
37:40 - DEBUG: New store game Subnautica (lutris_wine_2)
37:40 - DEBUG: DisplayManager done for lutris_wine_2
37:40 - DEBUG: New store game Euro Truck Simulator 2 (lutris_wine_3)
37:40 - DEBUG: DisplayManager done for lutris_wine_3
37:40 - DEBUG: New store game Kerbal Space Program (steam_220200)
37:40 - DEBUG: DisplayManager done for steam_220200
37:54 - DEBUG: Importing games from source steam
37:54 - DEBUG: Importing games from source desktop
37:54 - DEBUG: Importing games from source legendary
37:54 - INFO: Scanning source desktop
37:54 - DEBUG: Importing games from source itch
37:54 - DEBUG: Importing games from source retroarch
37:54 - INFO: Source legendary skipped, bad location
37:54 - DEBUG: Importing games from source lutris
37:54 - DEBUG: Importing games from source bottles
37:54 - DEBUG: Importing games from source flatpak
37:54 - DEBUG: Importing games from source heroic
37:54 - INFO: Source itch skipped, bad location
37:54 - INFO: Source retroarch skipped, bad location
37:54 - DEBUG: Resolved value for schema key steam-location: /home/portalbyte/.var/app/com.valvesoftware.Steam/data/Steam
37:54 - INFO: Source heroic skipped, bad location
37:54 - DEBUG: Import done for source legendary
37:54 - INFO: Scanning source steam
37:54 - DEBUG: Import done for source itch
37:54 - DEBUG: Import done for source retroarch
37:54 - DEBUG: Resolved value for schema key flatpak-system-location: /var/lib/flatpak
37:54 - DEBUG: Import done for source heroic
37:54 - INFO: Scanning source flatpak
37:54 - DEBUG: Duplicate store game Kerbal Space Program (steam_220200)
37:54 - DEBUG: Resolved value for schema key bottles-location: /home/portalbyte/.var/app/com.usebottles.bottles/data/bottles
37:54 - INFO: Scanning source bottles
37:54 - DEBUG: Resolved value for schema key lutris-location: /home/portalbyte/.var/app/net.lutris.Lutris/data/lutris
37:54 - INFO: Scanning source lutris
37:54 - DEBUG: Duplicate store game War Thunder (steam_236390)
37:54 - DEBUG: Import done for source bottles
37:54 - DEBUG: Import done for source steam
37:54 - DEBUG: Duplicate store game Songs of Conquest (lutris_wine_1)
37:54 - DEBUG: Duplicate store game Subnautica (lutris_wine_2)
37:54 - DEBUG: Duplicate store game Euro Truck Simulator 2 (lutris_wine_3)
37:54 - DEBUG: New store game Subnautica: Below Zero (lutris_wine_4)
37:54 - INFO: Imported Subnautica: Below Zero (lutris_wine_4)
37:54 - DEBUG: SteamAPIManager done for lutris_wine_4
37:54 - DEBUG: CoverManager done for lutris_wine_4
37:54 - DEBUG: Import done for source lutris
37:54 - DEBUG: SgdbManager done for lutris_wine_4
37:54 - DEBUG: Duplicate store game Prism Launcher (flatpak_org.prismlauncher.PrismLauncher)
37:54 - DEBUG: DisplayManager done for lutris_wine_4
37:54 - DEBUG: FileManager done for lutris_wine_4
37:54 - DEBUG: Import done for source flatpak
37:54 - DEBUG: Import done for source desktop
─────────────────────────────────────
40:20 - DEBUG: Starting page.kramo.Cartridges v2.8.5 (release)
40:20 - DEBUG: Python version: 3.11.9 (main, Nov 10 2011, 15:00:00) [GCC 13.2.0]
40:21 - DEBUG: Flatpak version: Flatpak 1.15.8
40:21 - DEBUG: Platform: Linux-6.9.5-zen1-1-zen-x86_64-with-glibc2.38
40:21 - DEBUG: 	System: Linux
40:21 - DEBUG: 	Node: glados
40:21 - DEBUG: 	Release: 6.9.5-zen1-1-zen
40:21 - DEBUG: 	Version: #1 ZEN SMP PREEMPT_DYNAMIC Sun, 16 Jun 2024 19:06:18 +0000
40:21 - DEBUG: 	Machine: x86_64
40:21 - DEBUG: 	Processor: 
40:21 - DEBUG: ─────────────────────────────────────
40:21 - DEBUG: New store game Prism Launcher (flatpak_org.prismlauncher.PrismLauncher)
40:21 - DEBUG: DisplayManager done for flatpak_org.prismlauncher.PrismLauncher
40:21 - DEBUG: New store game War Thunder (steam_236390)
40:21 - DEBUG: DisplayManager done for steam_236390
40:21 - DEBUG: New store game Songs of Conquest (lutris_wine_1)
40:21 - DEBUG: DisplayManager done for lutris_wine_1
40:21 - DEBUG: New store game Subnautica (lutris_wine_2)
40:21 - DEBUG: DisplayManager done for lutris_wine_2
40:21 - DEBUG: New store game Euro Truck Simulator 2 (lutris_wine_3)
40:21 - DEBUG: DisplayManager done for lutris_wine_3
40:21 - DEBUG: New store game Kerbal Space Program (steam_220200)
40:21 - DEBUG: DisplayManager done for steam_220200
40:21 - DEBUG: New store game Subnautica: Below Zero (lutris_wine_4)
40:21 - DEBUG: DisplayManager done for lutris_wine_4
41:21 - DEBUG: Resolved value for schema key bottles-location: /home/portalbyte/.var/app/com.usebottles.bottles/data/bottles
41:21 - DEBUG: Resolved value for schema key flatpak-system-location: /var/lib/flatpak
41:21 - DEBUG: Resolved value for schema key lutris-location: /home/portalbyte/.var/app/net.lutris.Lutris/data/lutris
41:21 - DEBUG: Resolved value for schema key steam-location: /home/portalbyte/.var/app/com.valvesoftware.Steam/data/Steam

System (please complete the following information):

  • OS: Arch Linux
  • Installation method: Flatpak
  • Cartridges version: 2.8.5
@portalbyte portalbyte added the bug Something isn't working label Jun 21, 2024
@kra-mo
Copy link
Owner

kra-mo commented Jun 29, 2024

Is this consistently reproducible?

@kra-mo kra-mo added the question Further information is requested label Jul 10, 2024
@marinabilles
Copy link

I am having this issue every single time I import a game that was added to Lutris. Yes, it is consistently reproducible.

@kra-mo kra-mo removed the question Further information is requested label Oct 15, 2024
@largestgithubuseronearth
Copy link
Contributor

It's pretty inconsistent and I've had it happen on Flatpaks as well. However, it seems there are certain games that will always cause it to stall out. For me, Lutris Quake Enhanced (GOG) and Lutris Fallout: New Vegas (GOG) always cause it to happen. It just so happens that both of these games have no cover art to import but not entirely sure if that's the root cause.

largestgithubuseronearth added a commit to largestgithubuseronearth/cartridges that referenced this issue Oct 31, 2024
@largestgithubuseronearth
Fix kra-mo#270: Import never finishes
b5bab17 
Removed GLib.idle_add from pipeline callback in importer.
It calls the pipeline callback too often, and so the
"pipeline done" counter is greater than the total game pipelines.

So if source task threads don't finish fast enough, then a race
condition occurs, and the importer can never be "finished" again,
and importing is permanently stalled.
Merged
largestgithubuseronearth added a commit to largestgithubuseronearth/cartridges that referenced this issue Oct 31, 2024
@largestgithubuseronearth
Fix kra-mo#270: Import never finishes
fc0c431 
Removed GLib.idle_add from pipeline callback in importer.
It calls the pipeline callback too often, and so the
"pipeline done" counter is greater than the total game pipelines.

So if source task threads don't finish fast enough, then a race
condition occurs, and the importer can never be "finished" again,
and importing is permanently stalled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Import never finishes largestgithubuseronearth/cartridges
4 participants
@marinabilles @largestgithubuseronearth @kra-mo @portalbyte