-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a way to configure a scope to factory function #29
Conversation
e635649
to
fc3f5a6
Compare
@@ -0,0 +1,20 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needless comments -- git annotate
will show who created what.
@aredridel mentioned perhaps the |
Not just default, but the only option. |
Yes, sorry. Semantics :) |
Ok then I´ll use |
In general, 'clean-up' fixes are good to add in a separate commit -- get the tests passing first, then add your tests + feature and make sure they still pass afterward. It's not super problematic -- and bad on us for letting the lint fail the tests! -- but just a good practice. Makes changes more reviewable in the future. |
fec575f
to
7f6ad82
Compare
@grawk @aredridel I´ve finished, please review as soon as you can. |
👍 |
Yep, LGTM. |
Adding a way to configure a scope to factory function
Adding a way to configure a scope to factory function
Adding a way to configure a scope to factory function
This code with a test helps solve the issue #26
The layout of the new configuration is added as a unit test, but you can see how it is below: