Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled toggle in flow controlled sections changed #59

Closed
jasisk opened this issue May 19, 2015 · 3 comments · Fixed by #61
Closed

Enabled toggle in flow controlled sections changed #59

jasisk opened this issue May 19, 2015 · 3 comments · Fixed by #61
Assignees
@jasisk
Labels
bug
Milestone
v3.0.2

Comments

@jasisk
Copy link
Contributor

jasisk commented May 19, 2015

Unconfirmed however I got a report from @lmarkus that the enabled toggle is broken for middlewares defined in flow-control sections starting with v3.x.
lmarkus pushed a commit to lmarkus/meddlewarePOC that referenced this issue May 19, 2015
POC for krakenjs/meddleware#59
328c275
@lmarkus
Copy link

lmarkus commented May 19, 2015

Here you go...
https://github.com/lmarkus/meddlewarePOC

@jasisk jasisk added the bug label May 19, 2015
@jasisk jasisk self-assigned this May 19, 2015
@jasisk jasisk added this to the v3.0.2 milestone May 19, 2015
@jasisk jasisk mentioned this issue May 22, 2015
Merged
@jasisk
Copy link
Contributor Author

jasisk commented May 26, 2015

https://github.com/krakenjs/meddleware/releases/tag/v3.0.2

Thanks for the report, @lmarkus!

@lmarkus
Copy link

lmarkus commented May 26, 2015

Thanks for a quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasisk jasisk

Labels
bug
Projects
None yet
Milestone
v3.0.2
Development

Successfully merging a pull request may close this issue.

fix regression: enabled toggle for composed sections krakenjs/meddleware
2 participants
@jasisk @lmarkus